1. 17 Jul, 2013 1 commit
  2. 11 Jul, 2013 1 commit
  3. 29 May, 2013 1 commit
  4. 21 Mar, 2013 1 commit
  5. 20 Nov, 2012 1 commit
  6. 08 Oct, 2012 1 commit
    • Iustin Pop's avatar
      Merge ganeti-master-cleaner back into ganeti-cleaner · 46118ed2
      Iustin Pop authored
      As I wrote during/after the review on commit 2958c56e
      
      , “ganeti-cleaner:
      Separate queue cleaning code”, while I appreciated the permission
      separation, I didn't like too much the file-based approach:
      
      - it is a very simple script, and lots of the code is duplicated
        between the two; I wouldn't like to see "ganeti-vmcapable-cleaner",
        "ganeti-master-candidate-cleaner", etc. in the future
      - ganeti-master-cleaner "pollutes" the namespace, creating
        tab-completion conflicts with ganeti-masterd
      
      This patch simply merges the master-cleaner back into cleaner, while
      keeping the separate user permissions scheme, separate log files, etc.
      
      Additionally, it fixes two bugs in the unit-test (not run with set -u
      and wrong path in the master-cleaner log files test; yay for even
      worse safety than Python?).
      
      And finally, since we have now support for --help-completion, it adds
      bash completion support for this script :) (needs to be applied on top
      of my argument support patch series).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      46118ed2
  7. 28 Sep, 2012 1 commit
  8. 27 Sep, 2012 2 commits
  9. 21 Sep, 2012 1 commit
  10. 12 Jun, 2012 1 commit
    • Iustin Pop's avatar
      Fix daemon-util with non-root user models · 3c29e49d
      Iustin Pop authored
      Commit 4b42c3d6
      
       broke non-root user mode since, while trying to do a
      cleanup a move all local variable definitions to the start of the
      function; however, the plain_name var is only defined later, so this
      actually doesn't work.
      
      Note that enabling set -u doesn't _directly_ work, since we rely on
      some variables which are usually undefined (EXTRA_*_ARGS, etc.). It
      can be fixed, but in a later patch.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      3c29e49d
  11. 23 May, 2012 1 commit
  12. 21 May, 2012 1 commit
  13. 28 Mar, 2012 1 commit
    • Michael Hanselmann's avatar
      ganeti.initd: Add “status” action · 8e2ed2e8
      Michael Hanselmann authored
      
      
      Eric Rostetter sent a patch adding a “status” action, but unfortunately
      his code was apparently specific to Red Hat. I hope this implementation
      is more distribution-agnostic; after all “status_of_proc” is part of
      LSB. Example output:
      
      $ /etc/init.d/ganeti status
      ganeti-noded is not running ... failed!
      ganeti-masterd is running.
      ganeti-rapi is running.
      ganeti-confd is running.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      8e2ed2e8
  14. 21 Dec, 2011 1 commit
    • Michael Hanselmann's avatar
      serializer: Remove JSON indentation and dict key sorting · a182a3ed
      Michael Hanselmann authored
      
      
      Serializing to JSON using “simplejson” is significantly slower when
      indentation and/or sorting of dictionary keys is used. In simplejson 1.x
      the difference isn't that big, but with simplejson 2.x the difference
      can be up to a factor of 7.5. The reason is that the latter no longer
      uses C functions when sorting or indentation is used.
      
      With this patch we revert everything to simplejson's defaults, which
      should provide us with the best performance available.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      a182a3ed
  15. 17 Nov, 2011 1 commit
  16. 30 Aug, 2011 1 commit
  17. 25 Aug, 2011 1 commit
  18. 19 Aug, 2011 1 commit
  19. 05 Aug, 2011 1 commit
  20. 04 Aug, 2011 1 commit
  21. 24 Mar, 2011 1 commit
  22. 06 Jan, 2011 1 commit
  23. 16 Dec, 2010 1 commit
    • Michael Hanselmann's avatar
      ensure-dirs: Speed up when using big queues · 196d70fa
      Michael Hanselmann authored
      
      
      The “ensure-dirs” script as included in Ganeti 2.3 is very slow when
      working with big queues requiring a change of permissions on many or all
      files.
      
      $ find /var/lib/ganeti/queue/ | wc -l
      52354
      
      Before this change:
      $ time /usr/local/lib/ganeti/ensure-dirs -f
      real    16m4.739s
      
      While not adressed in this patch, I'd like to record the overall
      ineffiency of the “ensure-dirs” script, even after this change:
      
      $ time /usr/local/lib/ganeti/ensure-dirs -f
      real    5m57.362s
      […]
      $ strace -e clone,execve -f -c /usr/local/lib/ganeti/ensure-dirs -f
      % time     seconds  usecs/call     calls    errors syscall
      ------ ----------- ----------- --------- --------- ----------------
       50.08    5.147090          49    104774           clone
       49.92    5.131094          49    104739           execve
      
      More changes will be needed. Just for comparision, a small Python
      snippet changing permissions on all files (“ensure-dirs” changes the
      owner too):
      
      $ time python -c 'import os; from ganeti import utils;
      [os.chmod(i, 0644) for i in
      utils.ListVisibleFiles("/var/lib/ganeti/queue/archive/big")]'
      real    0m0.605s
      […]
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      196d70fa
  24. 29 Nov, 2010 2 commits
  25. 19 Nov, 2010 1 commit
  26. 16 Nov, 2010 1 commit
  27. 29 Oct, 2010 6 commits
  28. 28 Oct, 2010 2 commits
  29. 26 Oct, 2010 1 commit
  30. 14 Oct, 2010 1 commit
    • Iustin Pop's avatar
      Add a new watcher option --ignore-pause · 46c8a6ab
      Iustin Pop authored
      
      
      During cluster maintenance, when the watcher is disabled, it's useful to
      run it just once. This is incovenient to do currently, as the watcher
      needs to be unpaused, then run, then paused again.
      
      This patch adds an option “--ignore-pause” that can be used to ignore
      the cluster-level setting. Also the man page is updated as it was
      missing the options available.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      46c8a6ab
  31. 13 Oct, 2010 2 commits
    • Michael Hanselmann's avatar
      Fix compatibility with Pyinotify 0.8 · ac96953d
      Michael Hanselmann authored
      
      
      I didn't know why the code previously used
      “pyinotify.EventsCodes.ALL_FLAGS” instead of using the flags from
      “pyinotify.EventsCodes” directly. Turns out that Pyinotify 0.8 has them
      in “pyinotify”, not “pyinotify.EventsCodes”.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      ac96953d
    • Michael Hanselmann's avatar
      ganeti-rapi: Watch directory, not file for user file changes · 073c31a5
      Michael Hanselmann authored
      
      
      We noticed several issues when just watching the file, among them race
      conditions upon replacing the file using rename(2) (the new watcher
      would be created too soon). By just watching the directory for events on
      the rapi_users file, this can be avoided.
      
      A nice side-effect is that now the users file is also reloaded if it
      didn't exist upon ganeti-rapi's start (see the documentation update).
      
      Since ganeti-rapi now becomes active for virtually every change in the
      configuration directory (…/lib/ganeti), moving the rapi_users file to a
      separate directory will be considered. It doesn't have to happen in or
      before this patch, though.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      073c31a5