1. 05 Sep, 2012 1 commit
  2. 04 Sep, 2012 16 commits
  3. 03 Sep, 2012 3 commits
    • Guido Trotter's avatar
      Instance autorepair design · 68640987
      Guido Trotter authored
      This design describes a tool that will perform automatic repairs on
      instances when they are detected to be unhealthy (living on offline or
      drained nodes, at the moment). These repairs can be scheduled
      automatically or requested as a one-off by a tool or person.
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarBernardo Dal Seno <bdalseno@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      68640987
    • Iustin Pop's avatar
      Add Query support for Nodes (no filtering, no RPC) · 046fe3f5
      Iustin Pop authored
      This is the initial support for Query2: basic infrastructure (except
      filtering) and node query support (without RPC).
      
      It implements all the fields (tests by comparison with list-fields on
      the Python side), except that:
      
      - filter is not done
      - since RPC is not integrated yet, the runtime gathering/computing is
        simply stubbed out
      
      However, the infrastructure seems pretty reasonable, so I'm sending as
      is.
      
      Note that I've split the functions/declarations into multiple files,
      to keep each file clean and readable.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      046fe3f5
    • Iustin Pop's avatar
      Stub query2 call integration into QueryD · 4cbe9bda
      Iustin Pop authored
      This patch corrects the definitions in Qlang.hs to match what Python
      expects on the wire; this means replacing some manual data type
      definitions with 'buildObject' so that we get serialisation (and field
      names) for free, adding (manually) JSON instances for types which are
      not represented as objects in JSON, etc. Due to more TH usage, I had
      to shift some definitions around, since TH breaks the "define in any
      order" property ().
      
      After that, we simply add a call into the stub Query/Query.hs module
      which, for all queries, responds with "query not supported". The
      reason for the deep directory structure is because I want to separate
      the functionality into multiple submodules, for smaller module size
      and readability.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      4cbe9bda
  4. 28 Aug, 2012 6 commits
    • Iustin Pop's avatar
      Reduce some more code duplication and split code · 62377cf5
      Iustin Pop authored
      The Qlang module defines ResultStatus, but it was already defined in
      Ganeti/Luxi.hs; let's remove the duplicate definition from there since
      the proper place is in the newer module.
      
      Also, in order to ease testing, we split some confd functions into a
      separate module; this can be imported easily into QC for testing.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      62377cf5
    • Iustin Pop's avatar
      Add configure-time switch for split queries · 42ab9ac4
      Iustin Pop authored
      And expand cli.GetClient() to allow opening the query socket, instead
      of the main master socket.
      
      Finally, enable the query socket use in gnt-cluster version, since
      that is already implemented fully in Queryd.hs/hconfd.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      42ab9ac4
    • Iustin Pop's avatar
      Rename Query2.hs to Qlang.hs · dc6a0f82
      Iustin Pop authored
      While starting to use the new filter types, I realised that what is
      currently implemented is the equivalent of `lib/qlang.py', not
      `lib/query.py', since we only deal with data types for now and not the
      actual query runtime functionality (RPC, config, etc.).
      
      Let's rename the file to be more consistent with the Python code base.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      dc6a0f82
    • Iustin Pop's avatar
      Re-enable standard hlint warnings · 2cdaf225
      Iustin Pop authored
      Commit 5a1e31b4 (Add infrastructure for, and two extra hlint rules)
      was intended to add two *extra* hlint rules, but I didn't realise at
      that time that "--hint" when first used overrides the built-in
      lints. As such, since then we were basically running with just those
      two rules, which resulted in many uncaught warnings/errors.
      
      This patch fixes that (by importing the standard lint rules in our
      custom hints file), and then goes to fix all the warnings that a
      current hlint gives me. Compared to our current style, we have just a
      few additions:
      
      - zipWithM instead of map foo . zip …
      - 'exitSuccess' instead of 'exitWith ExitSuccess'
      - more uses of '.'
      
      Additionally, we have to silence a case where hlint doesn't realise
      why we are using '\e -> const (return False (e :: IOError)' instead of
      just '\e -> return False' or even 'const (return False').
      
      One warning that is generated by hlint ("Use void") can't be fixed
      until we deprecate GHC 6.x, as only GHC 7 has the 'void' function in
      Control.Monad.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      2cdaf225
    • Iustin Pop's avatar
      Initial query daemon implementation · 25b54de0
      Iustin Pop authored
      This is just a new module that exports a runQueryD function, that can
      be imported to run a separate thread handling the luxi requests.
      
      Currently it needs access just to the configuration, in the future it
      will need access to an RPC runner too.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarAgata Murawska <agatamurawska@google.com>
      25b54de0
    • Agata Murawska's avatar
      Datatypes for haskell RPC calls · d4709cce
      Agata Murawska authored
      We introduce typeclasses for RPC call and result and create a typeclass
      that binds the two together. For that we need to use
      MultiParamTypeClasses and FunctionalDependencies language pragmas, which
      allow us to ensure that RPC result type can be deduced based on the
      RPC call type.
      Signed-off-by: default avatarAgata Murawska <agatamurawska@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      d4709cce
  5. 27 Aug, 2012 1 commit
  6. 23 Aug, 2012 1 commit
    • Iustin Pop's avatar
      Bump pep8 version to 1.2 · 5ae4945a
      Iustin Pop authored
      Debian Wheezy will ship with this version, and it has many improved checks compared to 0.6, so let's:
      
      - bump version in the docs
      - silence some new checks that are wrong due to our indent=2 instead of 4
      - fix lots of errors in the code where the indentation was wrong by 1
        or 2 spaces
      - fix a few cases of == True, False, None and replace with 'is'
      - re-indent some cases where the code is OK, but pep8 complains
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      5ae4945a
  7. 14 Aug, 2012 1 commit
  8. 09 Aug, 2012 1 commit
  9. 08 Aug, 2012 1 commit
  10. 23 Jul, 2012 8 commits
    • Iustin Pop's avatar
      Build epydoc.conf using standard replace_vars_sed · fc1282b8
      Iustin Pop authored
      This is just begging to be converted to a standard replace_vars_sed
      rule, instead of custom sed calls.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      fc1282b8
    • Iustin Pop's avatar
      Simplify some make rules · 55398706
      Iustin Pop authored
      A rule of type "a/%: a/%.in" will also match "a/b/%: a/b/%.in", so no
      need for the explicit examples/hooks rule. As for the man rules, they
      are identical and thus can be collapsed.
      
      We still have the problem that globally, not all our %.in to %
      transformations are identical; this is suboptimal and should be
      cleaned sometime…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      55398706
    • Iustin Pop's avatar
      Explicitly terminate some make rules · 490bec02
      Iustin Pop authored
      Generic rules like:
      
        %: %.in
      
      have the downside that the source (%.in) itself matches the target
      (via %.in: %.in.in). This leads to things like:
      
        Looking for a rule with intermediate file `doc/examples/hooks/ipsec.in.in'.
         Trying pattern rule with stem `ipsec.in.in'.
         Trying implicit prerequisite `doc/examples/hooks/ipsec.in.in.in'.
         Trying pattern rule with stem `ipsec.in.in'.
         Trying implicit prerequisite `doc/examples/hooks/ipsec.in.in.in'.
         Looking for a rule with intermediate file `doc/examples/hooks/ipsec.in.in.in'.
        Rejecting impossible implicit prerequisite `doc/examples/hooks/ipsec.in.in'.
      
      To fix this, we need to tell make that such rules are terminating, so
      that it doesn't recurse into them.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      490bec02
    • Iustin Pop's avatar
      Remove ancient implicit make rules · 1d45f7a0
      Iustin Pop authored
      GNU Make contains some (ancient) implicit rules, that try to
      _automatically_ extract source files from RCS/SCCS version control
      systems. This is unneeded, and it pollutes the make -d output
      significantly: after removing these rules (by defining empty targets
      for their patterns), make -d line count goes from 5.3K to 3.3K.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      1d45f7a0
    • Iustin Pop's avatar
      Stop using BUILT_SOURCES · 4c3d5fb6
      Iustin Pop authored
      Commit dc7d2c49 introduced the use of BUILT_SOURCES to work around
      missing dependencies. However, on closer reading of the gmake manual,
      BUILT_SOURCES is mainly used in cases where the dependencies are not
      know before the build starts (e.g. with auto-generated C header
      files). Additionally, there are a number of drawbacks to
      BUILT_SOURCES, which we already had to work around (e.g. in commit
      eb732fb5).
      
      Since we know all our dependencies statically, there's no need to use
      this special variable. Let's rename it to GENERATED_FILES, which
      doesn't have a special meaning to make, and add a few missing
      dependencies (one of which was already broken by make -j on a clean
      tree).
      
      After this change, running make in a fully built tree is finally "clean":
      
        $ make
        make: Nothing to be done for `all'.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      4c3d5fb6
    • Iustin Pop's avatar
      Change how we create the 'ganeti' symlink · 924ecd85
      Iustin Pop authored
      Currently, if one runs 'make' in an already fully-built tree, this is
      the result:
      
        cd . && test -h "ganeti" || { rm -f ganeti && ln -s lib ganeti; }
        make  all-am
        make[1]: Entering directory `/tmp/test'
        cd . && test -h "ganeti" || { rm -f ganeti && ln -s lib ganeti; }
        make[1]: Leaving directory `/tmp/test'
      
      This is because commit dc7d2c49 added 'ganeti' (which is a PHONY
      target) to BUILT_SOURCES, and since that is a dependency of other,
      real targets, it means the ganeti target is always remade.
      
      To fix this, we keep ganeti as a PHONY target, but we remove it from
      the 'built_base_sources' target, and instead we only remake it
      manually in the stamp-directories target. A make run now is just:
      
        make  all-am
        make[1]: Entering directory `/tmp/test'
        make[1]: Nothing to be done for `all-am'.
        make[1]: Leaving directory `/tmp/test'
      
      Note that we can't get rid of the all-am since we use BUILT_SOURCES.
      
      We also remove the comment of BUILT_SOURCES since it no longer depends
      on PHONY targets.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      924ecd85
    • Iustin Pop's avatar
      Partial undo of "Makefile: Streamline directory creation" · 3735787e
      Iustin Pop authored
      Commit c964d962 changed the way we create directories, by two things:
      
      - unifying all dependencies and ad-hoc directory creation into a
        single target (all_dirfiles)
      - changing how directories are created from a stamp file to .dir files
        in each directory
      
      The first item is a very good one, but the second item is debatable:
      there's no per-se advantage of .dir files versus a single one,
      top-level, since both the .dir file and stamp-directories creation are
      depending on Makefile, which is the only one which can introduce new
      directories.
      
      On the other hand, moving back from .dir files to stamp-directories
      has an advantage: "make -d | wc -l" does from ~8.7K lines to ~5.3K
      lines, because we eliminate the many .dir files and their multiple
      implicit and explicit dependencies (the %/.dir files fall under
      multiple patterns).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      3735787e
    • Iustin Pop's avatar
      A few style fixes in Makefile.am · 5098afd1
      Iustin Pop authored
      Seen while debugging make rules.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      5098afd1
  11. 20 Jul, 2012 1 commit