1. 27 Feb, 2009 2 commits
    • Iustin Pop's avatar
      Fix some epydoc style issues · 5fcc718f
      Iustin Pop authored
      99% of the epydoc return tags are "@return:", but each of the modified files
      had one "@returns:" line. We fix this for consistency.
      
      Reviewed-by: imsnah
      5fcc718f
    • Iustin Pop's avatar
      Convert the install document to restructured text. · 28e15341
      Iustin Pop authored
      This switches back to the hardcoding of the version number, as we don't
      yet have a wrapper for rst files that passes them through
      replace-sed-vars.
      
      Reviewed-by: imsnah
      28e15341
  2. 26 Feb, 2009 3 commits
    • Iustin Pop's avatar
      Fix the Makefile after the bash_completion patch · f72f8622
      Iustin Pop authored
      I've somehow left these two out. Sorry!
      
      Reviewed-by: imsnah
      f72f8622
    • Iustin Pop's avatar
      Add bash-completion rules · e2a2a2eb
      Iustin Pop authored
      This is a not-complete bash completion file for ganeti commands (gnt-*)
      and the burnin tool. It is based on previous work by Minghua Ye
      <yeminghua@google.com> for Ganeti 1.1, which wasn't used because the
      lack of ssconf keys (which allow easy inspection by the shell of the
      existing nodes and instances) made it too slow.
      
      The file works as expected, however I realized that our custom (like
      comma-separated, or a=b:c,e:f) options are not very nice for
      auto-completion. There are a few FIXMEs in the source for that.
      
      The file is not installed at make install time, but it should be put in
      the correct place by packages.
      
      Reviewed-by: imsnah
      e2a2a2eb
    • Michael Hanselmann's avatar
      Fix typos in utils.WriteFile's docstring · 69efe319
      Michael Hanselmann authored
      Reviewed-by: iustinp
      69efe319
  3. 25 Feb, 2009 5 commits
    • Iustin Pop's avatar
      Fix mixed pvm/hvm clusters and instance listing · b33b6f55
      Iustin Pop authored
      The current implementation of the combining of the instance lists will
      only do this for instances whose all four-fields match in both
      hypervisors; however, this is broken for the dynamic fields (state,
      times) which can change between the invocations of the two different
      hypervisors if the instance is busy.
      
      The patch checks only the memory and VCPUs, and makes mixed clusters
      work even with 100% CPU instances.
      
      Reviewed-by: imsnah
      b33b6f55
    • Iustin Pop's avatar
      Fix xen-hvm and KERNEL_ARGS · b399ce1e
      Iustin Pop authored
      xen-hvm doesn't have KERNEL_ARGS, and I just changed blindly all old
      extra_args to HV_KERNEL_ARGS. This makes xen-hvm work again.
      
      Reviewed-by: imsnah
      b399ce1e
    • Iustin Pop's avatar
      Update some version-related constants · f3e2e4c6
      Iustin Pop authored
      Since we are quite close to final RPC and hooks APIs, we update the hooks and
      protocol_version constants.
      
      Reviewed-by: imsnah
      f3e2e4c6
    • Iustin Pop's avatar
      Convert the hooks document to restructured text · 4d6443f4
      Iustin Pop authored
      This also updates the hooks document to 2.0.
      
      Reviewed-by: ultrotter
      4d6443f4
    • Iustin Pop's avatar
      Update some hooks settings · 2c2690c9
      Iustin Pop authored
      While reviewing the hooks document, I realised we are not correctly
      exporting the instance properties.
      
      This patch fixes:
        - export the disk and disk template in all LUs, not only (hardcoded)
          in the instance create
        - removes the instance create INSTANCE_ prefix on some non-instance
          variables (those are LU-related, not instance-related)
        - adds a couple of more variables to other LUs
      
      The hook document will be updated in a separate patch.
      
      Reviewed-by: ultrotter
      2c2690c9
  4. 24 Feb, 2009 7 commits
    • Iustin Pop's avatar
      Remove the extra_args parameter in instance start · 07813a9e
      Iustin Pop authored
      This patch removes the extra_args parameter and instead switches the
      instance to the HV_KERNEL_ARGS hypervisor option.
      
      This is a big change, but it's a needed cleanup, this extra parameter on
      all RPC calls is not generic and we also need to have a persistent value
      here.
      
      Reviewed-by: imsnah
      07813a9e
    • Iustin Pop's avatar
      Simplify a little the hypervisor routines · a985b417
      Iustin Pop authored
      Instead of “instance.hvparams”, we use a shorter “hvp” name to make readability
      better.
      
      Reviewed-by: imsnah
      a985b417
    • Iustin Pop's avatar
      Add definitions for the root_args hypervisor param · f9d6542d
      Iustin Pop authored
      This patch adds a new hypervisor parameter for the hypervisors that can
      actually start and instance with external kernels.
      
      Reviewed-by: imsnah
      f9d6542d
    • Iustin Pop's avatar
      Convert iallocator.sgml to restructured text · 876860a3
      Iustin Pop authored
      This is a no-contents change, this doc will need update to conform to
      2.0 message contents (and also the code will need increase to version 2
      of the iallocator protocol).
      
      Reviewed-by: imsnah
      876860a3
    • Iustin Pop's avatar
      Convert the admin guide to restructured text · ffa6869f
      Iustin Pop authored
      The RST format holds a little bit less information, as all the <file
      class="directory"> and <userinput> tags are gone, however we're not
      really losing important context here. And it's way easier to read and
      update.
      
      Reviewed-by: imsnah
      ffa6869f
    • Guido Trotter's avatar
      gnt-instance info: remove hvattr descriptions · dfff41f8
      Guido Trotter authored
      Having hvattr descriptions is only confusing for the user, because even
      if they explain better what an attribute is about, they don't help in
      deciding what keyword should be used to actually set it. If in the
      future we want descriptions they should probably live in constants.py,
      and be displayed together with the key, rather than instead of it.
      
      This patch also changes the handling of the vnc console connection
      description, making compatible work with both kvm and xen-hvm.
      
      Reviewed-by: iustinp
      dfff41f8
    • Iustin Pop's avatar
      Make gnt-instance info work with offline nodes · 9854f5d0
      Iustin Pop authored
      This simply makes LUQueryInstanceData return the same information as for
      a static query when one or both of the nodes are down.
      
      Reviewed-by: imsnah
      9854f5d0
  5. 20 Feb, 2009 2 commits
  6. 19 Feb, 2009 1 commit
  7. 17 Feb, 2009 2 commits
  8. 16 Feb, 2009 9 commits
    • Iustin Pop's avatar
      QA: add support for burnin rename · 4dc76b24
      Iustin Pop authored
      This patch adds support for optionally doing the rename burnin test, and
      adds an example to the sample QA file. To disable, either remove or
      specify an empty rename target.
      
      Reviewed-by: imsnah
      4dc76b24
    • Iustin Pop's avatar
      Fix some bugs in reboot · ae48ac32
      Iustin Pop authored
      There are two issues fixed in this patch:
        - first, the recent RPC changes caused loss of data in hard reboot
          type; we weren't reporting any results from the stop/start instance
          calls;
        - second, in soft or hard reboots, we didn't initialized the disk
          physical ID; based on the last state of the instance's disks, this
          can create a failure in identifying the disks
      
      After this patch, burnin works again with reboot, and reports errors
      correctly.
      
      Reviewed-by: imsnah
      ae48ac32
    • Iustin Pop's avatar
      Burnin: fix rename · 2e39ab98
      Iustin Pop authored
      In rename, we must stop different names in the first and second phases,
      so we create two different opcodes for this purpose (instead of using
      the same one twice, which doesn't work).
      
      Reviewed-by: imsnah
      2e39ab98
    • Iustin Pop's avatar
      Update NEWS for beta 2 · 2fb85b64
      Iustin Pop authored
      Reviewed-by: imsnah
      2fb85b64
    • Iustin Pop's avatar
      Convert IOErrors for /proc/drbd into our errors · f6eaed12
      Iustin Pop authored
      If /proc/drbd can't be opened, this raises an IOError, but all the
      error-handling behaviour in backend treats only BlockDeviceErrors. This
      creates a plain failure in cluster verify and in other RPC calls.
      
      This patch simply converts EnvironmentErrors into BlockDeviceErrors, and
      also changes the RPC result for NV_DRBDLIST and its handling to be able
      to show the error. The other RPC calls work by default now, due the
      existing error handling.
      
      Reviewed-by: ultrotter
      f6eaed12
    • Guido Trotter's avatar
      DEVNOTES: we have no --enable-rapi anymore · 04be7ec6
      Guido Trotter authored
      Remove it from the suggested development ./configure line
      
      Reviewed-by: iustinp
      04be7ec6
    • Guido Trotter's avatar
      Convert default root partition to msdos style · 1cd8141c
      Guido Trotter authored
      As discussed with 2.0 msdos partition style should be the default in the
      instance OS, so we're changing the default instance params accordingly.
      A followup patch will update the debootstrap os.
      
      Reviewed-by: iustinp
      1cd8141c
    • Iustin Pop's avatar
      watcher: fix checking of boot IDs · 3448aa22
      Iustin Pop authored
      The recent change (commit 2151) to the watcher to make it handle offline
      nodes also saves the offline attribute to the state file, but this is
      not needed and also breaks the checking of the boot ID. This patch
      simply removes it, restoring the correct behaviour.
      
      Reviewed-by: imsnah
      3448aa22
    • Iustin Pop's avatar
      watcher: autoarchive old jobs · f07521e5
      Iustin Pop authored
      This patch adds auto-archiving of jobs older than 6 hours to the
      watcher.
      
      Reviewed-by: imsnah
      f07521e5
  9. 13 Feb, 2009 9 commits
    • Iustin Pop's avatar
      RAPI: documentation updates · bf4a90af
      Iustin Pop authored
      This patch fixes the version and does some update to the RAPI resources
      docs.
      
      Reviewed-by: imsnah
      bf4a90af
    • Iustin Pop's avatar
      RAPI: fixes related to write mode · 6e99c5a0
      Iustin Pop authored
      This patch fixes many small issues related to write functions:
        - update documentations w.r.t. how to add users
        - update the instance add function for latest API
        - add instance delete
        - fix addition of tags
        - update some error messages
      
      Reviewed-by: imsnah
      6e99c5a0
    • Iustin Pop's avatar
      Some small improvements to the fake hypervisor · bfc30ec0
      Iustin Pop authored
      This patch modifies the fake hypervisor to substract the memory “used”
      by “running” instances from the free memory, so the actual node
      information changes based on the running instances.
      
      Also some style changes and fixes are added.
      
      Reviewed-by: ultrotter
      bfc30ec0
    • Iustin Pop's avatar
      Implement the backward-compatible ‘-s’ disk option · c0e4a2c3
      Iustin Pop authored
      This patch adds back to the instance creation command (gnt-instace add,
      gnt-backup import) the ‘-s’ short form option for specifying a
      single-disk instance.
      
      Also a small bug in gnt-backup import is fixed.
      
      Reviewed-by: ultrotter
      c0e4a2c3
    • Guido Trotter's avatar
      SetInstanceParams: export nic changes to hooks · d8dcf3c9
      Guido Trotter authored
      Currently we export the old instance "as is" and any nic changes get
      lost, so hooks won't know of a different ip, bridge, or mac address.
      This patch fixes it by putting the nics in the override dict, if any
      changes are done.
      
      Reviewed-by: iustinp
      d8dcf3c9
    • Guido Trotter's avatar
      Remove two fixed FIXME and convert one to TODO · ea5a5b74
      Guido Trotter authored
      The cli FIXME is not something broken, but rather some better handling
      feature we'd rather have, and the two backend FIXME are done (disks have
      their read only parameter set, and the error is raised and thus reaches
      the master).
      
      Reviewed-by: iustinp
      ea5a5b74
    • Iustin Pop's avatar
      RAPI: format error messages as JSON · 1f8588f6
      Iustin Pop authored
      This patch changes the format of the HTTP error messages from text/html, which
      is hard to parse from RAPI clients, to JSON which can be automatically parsed.
      
      The error message is an object, which contains always three keys:
        - code, an integer with the error code
        - message, a short description
        - explain, holding (if available) a description of the error
      
      In order to implement this, there is a bit of change to the http server
      and executor classes. I've tested and the error handling still works
      (but less optimal, no error message) in case the error formatting itself
      raises an exception.
      
      Reviewed-by: imsnah
      1f8588f6
    • Iustin Pop's avatar
      Make RAPI return 502/504 errors for luxi errors · 77e1d753
      Iustin Pop authored
      This changes the RAPI error codes for luxi errors; a timeout error is
      now reported properly as 504, while any other luxi error is reported as
      502.
      
      It would be good to convert even more errors into proper return codes in
      the future.
      
      Reviewed-by: imsnah
      77e1d753
    • Iustin Pop's avatar
      Fix ganeti-rapi startup with missing certificate · 6bb258a7
      Iustin Pop authored
      This patch displays a nicer error message compared to the default
      stacktrace.
      
      Reviewed-by: imsnah
      6bb258a7