1. 26 Jan, 2011 2 commits
  2. 06 Jan, 2011 1 commit
  3. 15 Dec, 2010 1 commit
    • Adeodato Simo's avatar
      Fix gnt-cluster verify with diskless instances · 4f5c2533
      Adeodato Simo authored
      
      
      `gnt-cluster verify` was failing with KeyError if there was any
      diskless instance in the cluster. This was because _CollectDiskInfo()
      was not including these instances in the returned dictionary, but they
      were expected to be present in LUVerifyCluster.Exec().
      
      With this commit, we ensure that the dictionary returned by _CollectDiskInfo
      includes entries for diskless instances as well.
      Signed-off-by: default avatarAdeodato Simo <dato@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      4f5c2533
  4. 09 Dec, 2010 1 commit
    • Iustin Pop's avatar
      Fix disk status verification in LUClusterVerify · d41d07d4
      Iustin Pop authored
      Commit b8d26c6e
      
       added disk status verification, but it has two
      (different) bugs for not healthy nodes.
      
      For offline nodes, we don't add at all the disk status to the
      instance/node dict, with the result that the instance is not present in
      the instdisk dict if all of its nodes are offline. This creates a
      KeyError later when we call VerifyInstance with instdisk[instance].
      
      For online nodes, but which don't return a valid disk status, we simply
      set the status to None for each disk, but the code in _VerifyInstance
      presumes and requires that each status is a valid tuple of length two.
      
      For both these bugs, we redo the instdisk computations to always include
      valid data, and we enhance the asserts to check for consistency.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      d41d07d4
  5. 18 Nov, 2010 2 commits
    • Iustin Pop's avatar
      Reinstall instance: disallow offline secondaries · 9aacb199
      Iustin Pop authored
      
      
      Currently, reinstallation of a DRBD instance with the secondary node offline does:
      
      node1# gnt-instance reinstall -f instance1
      Waiting for job 139053 for instance1...
      Thu Nov 18 01:36:09 2010  - WARNING: Could not prepare block device disk/0 on node node3 (is_primary=False, pass=1): Node is marked offline
      Thu Nov 18 01:36:09 2010  - WARNING: Could not shutdown block device disk/0 on node node3: Node is marked offline
      Job 139053 for instance1 has failed: Failure: command execution error:
      Disk consistency error
      
      Since this fails anyway, let's check the secondary nodes, thus
      preventing any modifications to the instance (e.g. OS type change):
      
      node1# gnt-instance reinstall -f instance1
      Waiting for job 139058 for instance1...
      Job 139058 for instance1 has failed: Failure: prerequisites not met for this operation:
      error type: wrong_state, error details:
      Instance secondary node offline, cannot reinstall: node3
      
      The patch needs modifications to the _CheckNodeOnline function, in order
      to display meaningful messages ("Can't use offline node" would be very
      confusing for an instance reinstall, since we didn't select a node
      manually).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      9aacb199
    • Iustin Pop's avatar
      Fix breakage in OS state modify · e2334900
      Iustin Pop authored
      
      
      I was using the feedback_fn function incorrectly (it doesn't
      automatically expand the arguments).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      e2334900
  6. 17 Nov, 2010 1 commit
  7. 03 Nov, 2010 1 commit
  8. 01 Nov, 2010 2 commits
  9. 28 Oct, 2010 11 commits
  10. 27 Oct, 2010 4 commits
  11. 26 Oct, 2010 7 commits
  12. 22 Oct, 2010 3 commits
  13. 21 Oct, 2010 2 commits
  14. 20 Oct, 2010 1 commit
  15. 19 Oct, 2010 1 commit