1. 19 Jan, 2012 1 commit
  2. 30 Aug, 2011 1 commit
  3. 25 Jul, 2011 1 commit
  4. 08 Mar, 2011 1 commit
  5. 03 Mar, 2011 1 commit
    • René Nussbaumer's avatar
      LUInstanceRename: Fail if renamed hostname mismatch · 31fe5102
      René Nussbaumer authored
      There's a problem if you run gnt-instance rename with a non FQDN and the
      renamed LU tries to resolve the hostname to make it FQDN. It could be
      that this resolved hostname was just a CNAME to another name which leads
      to wrongly renamed instances name.
      Given a name of "foobar" is a CNAME to "moohost" now if you gonna rewrite an
      instance named "foobar1" to "foobar" it will pickup the host "moohost".
      This is not obvious behaviour. If we detect this case we abort with a
      prereq error. The user then however can continue with a FQDN and
      --no-name-check if he intends to force the operation.
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
  6. 03 Feb, 2011 1 commit
  7. 12 Jan, 2011 2 commits
    • Iustin Pop's avatar
      Run pylint over QA code too · 3582eef6
      Iustin Pop authored
      Right now, the QA code is not covered by pylint, and this shows at
      least one low-impact bug.
      This patch does the necessary changes to make QA pylint-clean, and the
      changes the makefile to run pylint for it.
      Notable changes:
      - qa_utils.GenericQueryTest: randfields was not used at all, and my
        belief is that it was indented to be used in order not to modify the
        input list; so I replaced randfields with fields, so we only shuffle
        the our local copy
      - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I
        replaced it with the existing version
      - qa_os: was using 'dir' in a couple of places, replaced with dirname
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
    • Iustin Pop's avatar
      QA: use a persistent SSH connection to the master · f7e6f3c8
      Iustin Pop authored
      The recent additions to QA (many more tests) make QA slow if the
      machine on which the QA runs is not very close to the tested nodes —
      or in general, when the SSH handhaske is costly.
      We discussed before about using a persistent connection, and here is
      the patch that implements it. On a very small QA (very very small), it
      cuts down a lot of time (almost half), so it should be useful even for
      a full QA.
      I've also thought about changing from external ssh to paramiko, but I
      estimated that it would be more work to correctly interleave the IO
      from the remote process than just running a background SSH.
      Also note that yes, the global dict is ugly, but I don't know of
      another simple way to implement this.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
  8. 10 Jan, 2011 1 commit
  9. 21 Dec, 2010 1 commit
  10. 16 Dec, 2010 1 commit
  11. 14 Dec, 2010 1 commit
  12. 10 Dec, 2010 1 commit
  13. 29 Nov, 2010 1 commit
    • Iustin Pop's avatar
      Simplify QA commands · 2f4b4f78
      Iustin Pop authored
      Currently, 95% of the QA commands are executed in the same way: on the
      master, based on a command list and with expectancies for succes:
                               utils.ShellQuoteArgs(cmd)).wait(), 0)
      The rest 5% are variations on this theme (maybe the command needs to
      fail, or the node is different, etc.). Based on this, we can simplify
      the code significantly if we abstract the common theme into a new
      AssertCommand() function. This saves ~250 lines of code in the QA suite,
      around 8% of the entire QA code size.
      Additionally, the output was very cryptic before (the famous "QA error:
      1 != 0" messages), whereas now we show a clear error message (node,
      command, exit code and failure mode).
      The patch replaces single quotes with double quotes in all the parts of
      the code that I touch; let me know if that's not OK…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
  14. 01 Nov, 2010 1 commit
  15. 14 Jun, 2010 1 commit
  16. 11 May, 2010 1 commit
  17. 26 Mar, 2010 1 commit
  18. 05 Sep, 2008 1 commit
    • Michael Hanselmann's avatar
      QA: Remove dry run mode · 26a61f87
      Michael Hanselmann authored
      It didn't work as planned because some commands depend on the return
      value or output of some operations.
      Reviewed-by: iustinp
  19. 26 Aug, 2008 1 commit
  20. 18 Aug, 2008 1 commit
  21. 15 Aug, 2008 1 commit
  22. 14 Feb, 2008 1 commit
  23. 03 Dec, 2007 1 commit
  24. 22 Nov, 2007 1 commit
  25. 08 Nov, 2007 1 commit
  26. 01 Nov, 2007 1 commit
  27. 18 Oct, 2007 1 commit
  28. 15 Oct, 2007 1 commit
  29. 12 Oct, 2007 1 commit
  30. 10 Oct, 2007 1 commit
  31. 26 Sep, 2007 1 commit
    • Michael Hanselmann's avatar
      Enhance QA. · 5d640672
      Michael Hanselmann authored
      - Test “gnt-backup export” and “gnt-backup import”.
      - Move “ResolveInstanceName” to qa_utils.py.
      - Fix tests for “ganeti-watcher”.
      - Make instance shutdown and startup configurable.
      Reviewed-by: schreiberal
  32. 13 Sep, 2007 1 commit