1. 13 Jan, 2012 3 commits
    • Iustin Pop's avatar
      Further fixes to instance policy validation · 57dc299a
      Iustin Pop authored
      
      
      As a followup from "Remove extraneous check in policy creation", there
      are more places where we build an ipolicy, and then manually check for
      its validity. This is very bad style, as it duplicates the
      verification code across many places.
      
      This patch removes all such explicit checks (except for one in
      cmdlib.py which is correct), and instead does a bit more validation in
      the builder functions or in the actual dedicated verification
      functions. It also fixes cluster init which used the wrong,
      non-completed ipolicy (this was not detected before as we did call
      check on it, but otherwise we ignored it), and fixes a too-strong
      assert (due to the call chain, we first create the ipolicy from
      cmdline params, and only then we fill it).
      
      Finally, it removes an extraneous logging.info which I forgot from
      debugging.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      57dc299a
    • Iustin Pop's avatar
      Add new disk_templates parameter to instance policy · 2cc673a3
      Iustin Pop authored
      
      
      This is a bit more complex patch, as it requires changing the
      assumption that all keys in the policy dict points to values that are
      themselves dicts. Right now we introduce an assumption that any
      non-dicts are lists, we'll see in the future if this holds or whether
      we need more complex type checking (manual, yay Python).
      
      The patch also does some trivial style changes.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      2cc673a3
    • Iustin Pop's avatar
      Fix handling of errors from InstancePolicy.Check... · 363c0106
      Iustin Pop authored
      
      
      This code raises a configuration error, but we need to transform it
      into a prereq error (or possibly exec error), depending on when we
      call this function.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
      363c0106
  2. 12 Jan, 2012 1 commit
  3. 11 Jan, 2012 2 commits
  4. 10 Jan, 2012 4 commits
  5. 09 Jan, 2012 1 commit
  6. 06 Jan, 2012 8 commits
  7. 19 Dec, 2011 1 commit
  8. 16 Dec, 2011 2 commits
  9. 12 Dec, 2011 2 commits
  10. 09 Dec, 2011 3 commits
  11. 08 Dec, 2011 13 commits