1. 28 May, 2014 1 commit
  2. 17 Jan, 2014 1 commit
  3. 12 Dec, 2013 1 commit
  4. 09 Dec, 2013 1 commit
    • Dimitris Aragiorgis's avatar
      SetDiskID() before accepting an instance · a63985f3
      Dimitris Aragiorgis authored
      
      
      SetDiskID() fills physical_id slot of a Disk object.
      
      LUInstanceSetParams() does not invoke SetDiskID() upon creation of a
      new disk. As a result the physical_id slot of the Disk object in
      config data is missing.
      
      In case of ext disk template, in AcceptInstance() we invoke
      _GatherAndLinkBlockDevices(). This takes `instance` as an argument
      which includes current disks info. So, after adding a disk,
      migration of ext instances will fail because FindDevice() expects
      the physical_id slot.
      
      With this patch we invoke SetDiskID() for every disk of the instance
      before accept_instance() RPC.
      
      Fixes Issue 633.
      Signed-off-by: default avatarDimitris Aragiorgis <dimara@grnet.gr>
      Signed-off-by: default avatarMichele Tartara <mtartara@google.com>
      Reviewed-by: default avatarMichele Tartara <mtartara@google.com>
      a63985f3
  5. 24 Sep, 2013 2 commits
  6. 30 Jul, 2013 1 commit
  7. 02 Jul, 2013 1 commit
  8. 20 Jun, 2013 1 commit
    • Thomas Thrainer's avatar
      Index instances by their UUID · da4a52a3
      Thomas Thrainer authored
      
      
      No longer index instances by their name but by their UUID in the cluster
      config. This change changes large parts of the code, as the following
      adjustments were necessary:
       * Change the index key to UUID in the configuration and the
         ConfigWriter, including all methods.
       * External interfaces (command line interface, IAllocator interface,
         hook scripts, etc.) are kept stable.
       * Instance UUID's are resolved in ExpandNames and then stored in the
         OpCode. This allows to check for instance renames if the OpCode is
         reloaded after a cluster restart. This check is currently only done
         for single instance parameters.
       * Instance locking unfortunately can't use instances UUID as
         identifiers. The reasons is that new instances (which have no UUID
         yet) have to be locked as well, so the instance name is used.
       * Variable names are renamed to follow the following pattern:
         - Suffix is 'inst' or 'insts': Variable holds Instance objects
         - Suffix is 'name' or 'names': Variable holds Instance names
         - Suffix is 'uuid' or 'uuids': Variable holds Instance UUID's
       * Tests are adapted.
      Signed-off-by: default avatarThomas Thrainer <thomasth@google.com>
      Reviewed-by: default avatarKlaus Aehlig <aehlig@google.com>
      da4a52a3
  9. 13 Jun, 2013 3 commits
    • Thomas Thrainer's avatar
      Inline simple "alias" variables · d0d7d7cf
      Thomas Thrainer authored
      
      
      Remove variables in the form "var = self.var" throughout all LU's. Those
      "alias" variables make it harder to read the code (it's no longer
      immediately clear what's a field and what's a local variable), and can
      introduce subtle bug (especially when not used consistently and when
      they are re-assigned).
      Signed-off-by: default avatarThomas Thrainer <thomasth@google.com>
      Reviewed-by: default avatarKlaus Aehlig <aehlig@google.com>
      d0d7d7cf
    • Thomas Thrainer's avatar
      Index nodes by their UUID · 1c3231aa
      Thomas Thrainer authored
      
      
      No longer index nodes by their name but by their UUID in the cluster
      config. This change changes large parts of the code, as the following
      adjustments were necessary:
       * Change the index key to UUID in the configuration and the
         ConfigWriter, including all methods.
       * Change all cross-references to nodes to use UUID's.
       * External interfaces (command line interface, IAllocator interface,
         hook scripts, etc.) are kept stable.
       * RPC-calls can resolve UUID's as target node arguments, if the RPC
         runner is based on a ConfigWriter instance. The result dictionary is
         presented in the form the nodes are addressed: by UUID if UUID's were
         given, or by name if names were given.
       * Node UUID's are resolved in ExpandNames and then stored in the
         OpCode. This allows to check for node renames if the OpCode is
         reloaded after a cluster restart. This check is currently only done
         for single node parameters.
       * Variable names are renamed to follow the following pattern:
         - Suffix is 'node' or 'nodes': Variable holds Node objects
         - Suffix is 'name' or 'names': Variable holds node names
         - Suffix is 'uuid' or 'uuids': Variable holds node UUID's
       * Tests are adapted.
      Signed-off-by: default avatarThomas Thrainer <thomasth@google.com>
      Reviewed-by: default avatarKlaus Aehlig <aehlig@google.com>
      1c3231aa
    • Helga Velroyen's avatar
      Add cluster name to instance migration RPC · bc0a2284
      Helga Velroyen authored
      
      
      This fixes a 'FIXME' in the xen hypervisor. The instance
      migration requires the cluster's name. This should come
      from the RPC call, but so far was hackishly taken from
      ssconf. Ssconf is intended to be used by scripts only and
      not by the backend itself.
      Signed-off-by: default avatarHelga Velroyen <helgav@google.com>
      Reviewed-by: default avatarThomas Thrainer <thomasth@google.com>
      bc0a2284
  10. 12 Jun, 2013 3 commits
  11. 28 May, 2013 1 commit
  12. 17 May, 2013 2 commits