1. 20 Nov, 2012 4 commits
  2. 12 Sep, 2012 2 commits
  3. 23 Aug, 2012 2 commits
    • Iustin Pop's avatar
      Bump pep8 version to 1.2 · 5ae4945a
      Iustin Pop authored
      Debian Wheezy will ship with this version, and it has many improved checks compared to 0.6, so let's:
      - bump version in the docs
      - silence some new checks that are wrong due to our indent=2 instead of 4
      - fix lots of errors in the code where the indentation was wrong by 1
        or 2 spaces
      - fix a few cases of == True, False, None and replace with 'is'
      - re-indent some cases where the code is OK, but pep8 complains
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
    • Iustin Pop's avatar
      Change node parameter oob_program to VTYPE_STRING · 1df4d430
      Iustin Pop authored
      Since this is an inheritable parameter, having it as a MABYE_STRING
      creates only problems (per our derivation rules). We change it to
      STRING, with the default "", meaning no program. Note that most of the
      code already accepts this as valid for "no program", and some comments
      even say that this is the expected value.
      We have some other parameters like this, I'll have to investigate
      whether they need to be changed too. But right now I need this for the
      hconfd changes (it's a prerequisite for them, I forgot to send it in
      that patch series).
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
  4. 27 Jul, 2012 1 commit
  5. 19 Jul, 2012 1 commit
    • René Nussbaumer's avatar
      Fix setting ipolicy on node groups · 8b057218
      René Nussbaumer authored
      On node groups we don't have the std field. However, the InstancePolicy
      object always verifies that the std value is within a given range. As we
      fill it up with defaults if not set (as it happens to be on node groups)
      and the min value is higher than the default std value (taken from
      constants.py) we fail.
      We overcome this situation by simply let the function know if we want to
      verify the std value at all. If we don't want to verify std, we just set
      it to a compliant value (min_v) and continue.
      We also slightly adapt the error message provided, as we don't have std
      values on groups.
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
  6. 18 Jul, 2012 1 commit
  7. 17 Jul, 2012 1 commit
  8. 15 May, 2012 1 commit
  9. 14 May, 2012 1 commit
  10. 10 May, 2012 5 commits
  11. 18 Apr, 2012 1 commit
  12. 21 Feb, 2012 3 commits
  13. 26 Jan, 2012 4 commits
  14. 25 Jan, 2012 1 commit
  15. 24 Jan, 2012 1 commit
  16. 23 Jan, 2012 2 commits
  17. 13 Jan, 2012 2 commits
    • Iustin Pop's avatar
      Further fixes to instance policy validation · 57dc299a
      Iustin Pop authored
      As a followup from "Remove extraneous check in policy creation", there
      are more places where we build an ipolicy, and then manually check for
      its validity. This is very bad style, as it duplicates the
      verification code across many places.
      This patch removes all such explicit checks (except for one in
      cmdlib.py which is correct), and instead does a bit more validation in
      the builder functions or in the actual dedicated verification
      functions. It also fixes cluster init which used the wrong,
      non-completed ipolicy (this was not detected before as we did call
      check on it, but otherwise we ignored it), and fixes a too-strong
      assert (due to the call chain, we first create the ipolicy from
      cmdline params, and only then we fill it).
      Finally, it removes an extraneous logging.info which I forgot from
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
    • Iustin Pop's avatar
      Add new disk_templates parameter to instance policy · 2cc673a3
      Iustin Pop authored
      This is a bit more complex patch, as it requires changing the
      assumption that all keys in the policy dict points to values that are
      themselves dicts. Right now we introduce an assumption that any
      non-dicts are lists, we'll see in the future if this holds or whether
      we need more complex type checking (manual, yay Python).
      The patch also does some trivial style changes.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
  18. 11 Jan, 2012 1 commit
  19. 09 Dec, 2011 1 commit
  20. 08 Dec, 2011 5 commits