1. 31 Jan, 2012 1 commit
  2. 19 Jan, 2012 1 commit
  3. 17 Jan, 2012 1 commit
    • Iustin Pop's avatar
      Rework instance rename QA tests · 4c1a464b
      Iustin Pop authored
      After looking again at the QA speeds, it turned out that instance
      rename was run 12 times via the command line and 12 times via RAPI;
      outside of start/stop which we need for maintenance during QA, this is
      the most used test.
      This patch does a few changes with regard to instance rename:
      - it changes rename functions to rename the instance back to the
        original name
      - which allows us not to run said functions twice, A→B and then B→A
      This brings down the number of rename tests from 12 to 8 (for both
      cmdline and RAPI).
      Furthermore, the CLI rename test was doing too many actual instance
      renames (at Ganeti level), so we rework it to be simpler (brings down
      the average duration from ~27s to ~21s), and we reorganise the run of
      various tests such that we do fewer instances start/stop tests (10
      instead of 14).
      Overall we only gain about 3 minutes (~7%), but still it's a speedup.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarRené Nussbaumer <rn@google.com>
  4. 08 Dec, 2011 1 commit
  5. 22 Nov, 2011 1 commit
  6. 30 Aug, 2011 1 commit
  7. 25 Jul, 2011 1 commit
  8. 06 Apr, 2011 1 commit
  9. 15 Mar, 2011 1 commit
  10. 03 Mar, 2011 1 commit
    • René Nussbaumer's avatar
      LUInstanceRename: Fail if renamed hostname mismatch · 31fe5102
      René Nussbaumer authored
      There's a problem if you run gnt-instance rename with a non FQDN and the
      renamed LU tries to resolve the hostname to make it FQDN. It could be
      that this resolved hostname was just a CNAME to another name which leads
      to wrongly renamed instances name.
      Given a name of "foobar" is a CNAME to "moohost" now if you gonna rewrite an
      instance named "foobar1" to "foobar" it will pickup the host "moohost".
      This is not obvious behaviour. If we detect this case we abort with a
      prereq error. The user then however can continue with a FQDN and
      --no-name-check if he intends to force the operation.
      Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
  11. 25 Feb, 2011 1 commit
  12. 12 Jan, 2011 1 commit
    • Iustin Pop's avatar
      Run pylint over QA code too · 3582eef6
      Iustin Pop authored
      Right now, the QA code is not covered by pylint, and this shows at
      least one low-impact bug.
      This patch does the necessary changes to make QA pylint-clean, and the
      changes the makefile to run pylint for it.
      Notable changes:
      - qa_utils.GenericQueryTest: randfields was not used at all, and my
        belief is that it was indented to be used in order not to modify the
        input list; so I replaced randfields with fields, so we only shuffle
        the our local copy
      - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I
        replaced it with the existing version
      - qa_os: was using 'dir' in a couple of places, replaced with dirname
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
  13. 14 Dec, 2010 1 commit
  14. 10 Dec, 2010 1 commit
  15. 09 Dec, 2010 1 commit
    • Guido Trotter's avatar
      Simplify instance rename qa test · e5c2accd
      Guido Trotter authored
      The current instance rename qa testing function can only perform
      back-and-forth renames, both for command line and rapi. In order to be
      able to perform same-name rename tests we change it to be able to
      perform simple renames, and then we change qa to call it to perform both
      sides of the renaming.
      The same change is applied both to the local and the rapi test.
      Signed-off-by: default avatarGuido Trotter <ultrotter@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
  16. 29 Nov, 2010 1 commit
    • Iustin Pop's avatar
      Simplify QA commands · 2f4b4f78
      Iustin Pop authored
      Currently, 95% of the QA commands are executed in the same way: on the
      master, based on a command list and with expectancies for succes:
                               utils.ShellQuoteArgs(cmd)).wait(), 0)
      The rest 5% are variations on this theme (maybe the command needs to
      fail, or the node is different, etc.). Based on this, we can simplify
      the code significantly if we abstract the common theme into a new
      AssertCommand() function. This saves ~250 lines of code in the QA suite,
      around 8% of the entire QA code size.
      Additionally, the output was very cryptic before (the famous "QA error:
      1 != 0" messages), whereas now we show a clear error message (node,
      command, exit code and failure mode).
      The patch replaces single quotes with double quotes in all the parts of
      the code that I touch; let me know if that's not OK…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
  17. 01 Nov, 2010 2 commits
  18. 10 Aug, 2010 2 commits
  19. 29 Jul, 2010 1 commit
  20. 07 Jul, 2010 1 commit
  21. 01 Jul, 2010 1 commit
  22. 22 Apr, 2010 1 commit
  23. 15 Mar, 2010 1 commit
  24. 12 Feb, 2010 1 commit
  25. 09 Feb, 2010 1 commit
  26. 11 May, 2009 1 commit
  27. 01 Dec, 2008 1 commit
  28. 15 Aug, 2008 1 commit
  29. 06 Jun, 2008 3 commits
  30. 27 Mar, 2008 1 commit
  31. 25 Mar, 2008 1 commit
    • Iustin Pop's avatar
      Remove the option to create md/drbd7 instances · f9193417
      Iustin Pop authored
      This patch removes the options that allow to create local_raid1 or
      remote_raid1 instances. It also modifies the documentation and removes
      these disk templates from burnin and from qa.
      Reviewed-by: imsnah
  32. 25 Feb, 2008 1 commit
  33. 14 Feb, 2008 1 commit
  34. 28 Jan, 2008 1 commit
    • Iustin Pop's avatar
      Add QA tests for gnt-instance modify · c0f74c55
      Iustin Pop authored
      This patch adds QA tests for most of the possible parameters in the
      instance modify operation (exception being the MAC), and modifies the
      sample QA file to run this test.
      It also tests the no-modification test, but that is a weak one: we only
      test that the exit code is one, not that the command gave a proper
      response ("... please give at least one parameter") as opposed to a
      Reviewed-by: imsnah
  35. 21 Jan, 2008 2 commits
    • Guido Trotter's avatar
      Remove qa tests for gnt-instance start/stop · e0b62a26
      Guido Trotter authored
      Those tests were added in the wrong place. This patch removes them.  One day
      we'll implement proper command line regression testing and they should go in
      Reviewed-by: iustinp
    • Guido Trotter's avatar
      Test start/stop aliases in qa · ce9fb89d
      Guido Trotter authored
      This tests both that those two aliases have not been removed and also that
      aliases handling hasn't been broken.
      Reviewed-by: iustinp