- 31 Jan, 2012 1 commit
-
-
Michael Hanselmann authored
Instead of having two separate parameters, a single boolean parameter is used. Unfortunately we need a third state to say “no change”, so the value can be None, True or False (similar to other parameters). There are no user interface changes. New QA tests are added, too. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
- 26 Jan, 2012 1 commit
-
-
Iustin Pop authored
… and add the disk_templates/vcpu_ratio new entries. Since the default ispecs_* are dicts, we can't compare them to none. Additionally, add a QA test for this case (empty cluster modify). Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 17 Jan, 2012 1 commit
-
-
Iustin Pop authored
After looking again at the QA speeds, it turned out that instance rename was run 12 times via the command line and 12 times via RAPI; outside of start/stop which we need for maintenance during QA, this is the most used test. This patch does a few changes with regard to instance rename: - it changes rename functions to rename the instance back to the original name - which allows us not to run said functions twice, A→B and then B→A This brings down the number of rename tests from 12 to 8 (for both cmdline and RAPI). Furthermore, the CLI rename test was doing too many actual instance renames (at Ganeti level), so we rework it to be simpler (brings down the average duration from ~27s to ~21s), and we reorganise the run of various tests such that we do fewer instances start/stop tests (10 instead of 14). Overall we only gain about 3 minutes (~7%), but still it's a speedup. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- 05 Jan, 2012 1 commit
-
-
Andrea Spadaccini authored
Fix an error in the disk parameters tests (the arguments to gnt-cluster were not passed correctly) and move them to separate functions. Signed-off-by:
Andrea Spadaccini <spadaccio@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 04 Nov, 2011 1 commit
-
-
Michael Hanselmann authored
This would have caught a bug introduced with the recent RPC changes. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 17 Oct, 2011 1 commit
-
-
Michael Hanselmann authored
Commit d1c172de inadvertently changes the “/2/instances/[instance_name]/replace-disks” resource to use body parameters. There were no QA tests and the issue wasn't noticed. This patch re-introduces support for query parameters and adds a QA test. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Andrea Spadaccini <spadaccio@google.com>
-
- 22 Sep, 2011 1 commit
-
-
Michael Hanselmann authored
This would have detected the issue fixed in the previous patch. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- 30 Aug, 2011 2 commits
-
-
Andrea Spadaccini authored
- Makefile.am: added QA directory to the paths checked by pep8 - qa/: fixed the reported errors - Makefile.am: also, added qa_group.py to qa_scripts Signed-off-by:
Andrea Spadaccini <spadaccio@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Andrea Spadaccini authored
In version 0.21, pylint unified all the disable-* (and enable-*) directives to disable (resp. enable). This leads to a lot of DeprecationWarning being emitted even if one uses the recommended version of pylint (0.21.1, as stated in devnotes.rst). This commit changes all the disable-msg directives to disable. Signed-off-by:
Andrea Spadaccini <spadaccio@google.com> Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 25 Jul, 2011 1 commit
-
-
Iustin Pop authored
s/'/"/ in (hopefully) the right places. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 21 Jul, 2011 1 commit
-
-
Michael Hanselmann authored
No idea why this was missed before. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 16 May, 2011 1 commit
-
-
Iustin Pop authored
Instead of hardcoded Xen commands. This will make it work for all hypervisors, instead of duplicating hypervisor functionality in QA itself. The timeout has been removed as gnt-instance stop itself will make sure the instance is down before returning. We just double-check that it is indeed down. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- 21 Apr, 2011 2 commits
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 14 Apr, 2011 2 commits
-
-
Iustin Pop authored
So that we don't happen again to break this forever without realising it. The patch also replaces one ' with ". Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
This was (AFAICS) completely missing from the QA suite. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Guido Trotter <ultrotter@google.com>
-
- 15 Mar, 2011 1 commit
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- 08 Mar, 2011 2 commits
-
-
Michael Hanselmann authored
- Test OS lists via command line and RAPI - Test “gnt-os diagnose” and “gnt-os info” Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Michael Hanselmann authored
Also add an additional check to ensure the OS does not exist. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 28 Feb, 2011 1 commit
-
-
Michael Hanselmann authored
- Move functions for drain status (tracked via file) from jqueue to jstore - Undrain queue on master failover if necessary - Add QA test Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 24 Feb, 2011 1 commit
-
-
René Nussbaumer authored
This is a convenience command to do an automated EPO in the possible limits of Ganeti. Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 18 Feb, 2011 1 commit
-
-
Guido Trotter authored
This tests at least the basic case, unfortunately there is no way to check all possibilities using the provided rapi client, as that will use the new method unless the cluster doesn't support it. Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 28 Jan, 2011 2 commits
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Michael Hanselmann authored
Add “cluster-oob” to sample configuration file. Don't run RAPI group tests if disabled. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 12 Jan, 2011 3 commits
-
-
Iustin Pop authored
Right now, the QA code is not covered by pylint, and this shows at least one low-impact bug. This patch does the necessary changes to make QA pylint-clean, and the changes the makefile to run pylint for it. Notable changes: - qa_utils.GenericQueryTest: randfields was not used at all, and my belief is that it was indented to be used in order not to modify the input list; so I replaced randfields with fields, so we only shuffle the our local copy - qa_node.TestOutOfBand was using it's own copy of AcquireNode(), so I replaced it with the existing version - qa_os: was using 'dir' in a couple of places, replaced with dirname Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
The recent additions to QA (many more tests) make QA slow if the machine on which the QA runs is not very close to the tested nodes — or in general, when the SSH handhaske is costly. We discussed before about using a persistent connection, and here is the patch that implements it. On a very small QA (very very small), it cuts down a lot of time (almost half), so it should be useful even for a full QA. I've also thought about changing from external ssh to paramiko, but I estimated that it would be more work to correctly interleave the IO from the remote process than just running a background SSH. Also note that yes, the global dict is ugly, but I don't know of another simple way to implement this. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
Iustin Pop authored
Patch f55312bd added the OOB tests to TestClusterVerify, which is not actually a test for cluster verify, but a runner for cluster verify that is called multiple times, for each instance type, etc. This led to running the OOB commands multiple times, which is painful especially as this is a slow test. The patch moves this to a separate test, that is run only once. Furthermore, the way that data files are copied around is very inefficient: touch + mv + chmod + mv + rm for each node (5 times number of nodes), whereas it could be simply: touch on master, chmod on master, cluster copyfile, chmod on master, cluster copyfile, cluster command rm, i.e. only 5 fixed ssh calls to the master. The code is changed as such, for increased speed. Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 10 Jan, 2011 1 commit
-
-
Adeodato Simo authored
Signed-off-by:
Adeodato Simo <dato@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 06 Jan, 2011 1 commit
-
-
Adeodato Simo authored
Now that group queries use query2 infrastructure, update the QA tests to use the generic functions in qa_utils.py. Signed-off-by:
Adeodato Simo <dato@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 20 Dec, 2010 1 commit
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 17 Dec, 2010 2 commits
-
-
Michael Hanselmann authored
“gnt-cluster verify” looks at some per-instance information as well, so it should be run for each instance type QA tests. Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 16 Dec, 2010 1 commit
-
-
René Nussbaumer authored
Signed-off-by:
René Nussbaumer <rn@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 14 Dec, 2010 1 commit
-
-
Michael Hanselmann authored
Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
René Nussbaumer <rn@google.com>
-
- 13 Dec, 2010 1 commit
-
-
Adeodato Simo authored
This adds QA tests for the SetGroupParams operation, both for CLI and RAPI. Additionally, it adds tests for add/rename/remove groups via RAPI, which had not been included in a previous patch series. Finally, it also tests setting "alloc_policy" (and, for the CLI, "ndparams") at group creation time. Signed-off-by:
Adeodato Simo <dato@google.com> Reviewed-by:
Michael Hanselmann <hansmi@google.com>
-
- 10 Dec, 2010 1 commit
-
-
Michael Hanselmann authored
- Query all known fields - Random combinations (using a PRNG with a fixed seed) of fields - Order of result names Signed-off-by:
Michael Hanselmann <hansmi@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 09 Dec, 2010 2 commits
-
-
Guido Trotter authored
Use the simplified command and rapi version to perform an instance rename to the same name. This is performed anytime the rename test is enabled, while the "other-name" rename is performed when also an alternative name is provided. Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
Guido Trotter authored
The current instance rename qa testing function can only perform back-and-forth renames, both for command line and rapi. In order to be able to perform same-name rename tests we change it to be able to perform simple renames, and then we change qa to call it to perform both sides of the renaming. The same change is applied both to the local and the rapi test. Signed-off-by:
Guido Trotter <ultrotter@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 08 Dec, 2010 1 commit
-
-
Adeodato Simo authored
This is a single function that tests all of of the following: - creating groups - creating groups that exist fails - renaming an empty group - renaming a group with nodes - renaming to a name that already exists fails - removing an empty group works - removing a group with nodes fails The "default" group is only used for the "rename group with nodes" test. Signed-off-by:
Adeodato Simo <dato@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-
- 01 Dec, 2010 1 commit
-
-
Adeodato Simo authored
This adds QA tests for both CLI and RAPI. Signed-off-by:
Adeodato Simo <dato@google.com> Signed-off-by:
Iustin Pop <iustin@google.com> Reviewed-by:
Iustin Pop <iustin@google.com>
-