1. 12 Feb, 2013 1 commit
  2. 14 Jan, 2013 1 commit
  3. 08 Jan, 2013 1 commit
    • Michele Tartara's avatar
      Support instance-minor pairing in the DRBD collector · d78970ba
      Michele Tartara authored
      This commits enables the DRBD data collector to use the Confd client to
      gather information about the pairing between DRBD minors and instances.
      
      For testing purposes, the DRBD data collector now requires either zero
      or two parameters: one is the DRBD file, one is the pairings file.
      When no parameter is passed, the collector is in "production mode" and takes
      the data from /proc/drbd and from the Confd client.
      
      The shell tests of mon-collector are updated accordingly.
      Signed-off-by: default avatarMichele Tartara <mtartara@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      d78970ba
  4. 27 Dec, 2012 1 commit
    • Iustin Pop's avatar
      Move htest/ files under the test/ tree · 83846468
      Iustin Pop authored
      htest/data becomes test/data/htools (basically reverting commit
      8feabc89), and htest/* becomes test/hs/*.
      
      Most changes beside the rename are trivial s/…/…, with the exception
      of autotools/run-in-tempdir, which needed some more changes now that
      test/ is not just Python files:
      
      - test/py is still being copied
      - test/hs moves from individual symlinks to entire dir symlink
      - test/data is symlinked in its entirety
      
      Checked with make distcheck, pep8 and pylint, so at least VPATH builds
      are OK.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      83846468
  5. 20 Nov, 2012 2 commits
  6. 23 Oct, 2012 1 commit
  7. 17 Oct, 2012 2 commits
  8. 04 Sep, 2012 1 commit
  9. 28 Jun, 2012 1 commit
  10. 11 May, 2012 1 commit
    • Iustin Pop's avatar
      Workaround changed LVM behaviour · 4c5dd3ff
      Iustin Pop authored
      The vgreduce command has changed behaviour from when we initially
      wrote the code (2.02.02 versus 2.02.66, 4 years delta):
      
      - if there are LVs which will be impacted, it requires --force
      - otherwise refuses to proceed, but it still returns exit code 0
      
      We handle this by looking to see if it returns "Wrote out consistent
      volume group" (behaviour unchanged), or if it complains about
      "--force"; in the case it didn't complete, we retry the operation.
      
      We improve a bit the checking of "vgs", as it uses to fail silently
      and we didn't detect it.
      
      New tests for this function should test, I believe, all the expected
      variations; at the least we now have data files with the expected
      output.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      (cherry picked from commit 048eeb2b)
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      4c5dd3ff
  11. 15 Mar, 2012 3 commits
  12. 15 Feb, 2012 1 commit
    • Iustin Pop's avatar
      Workaround changed LVM behaviour · 048eeb2b
      Iustin Pop authored
      The vgreduce command has changed behaviour from when we initially
      wrote the code (2.02.02 versus 2.02.66, 4 years delta):
      
      - if there are LVs which will be impacted, it requires --force
      - otherwise refuses to proceed, but it still returns exit code 0
      
      We handle this by looking to see if it returns "Wrote out consistent
      volume group" (behaviour unchanged), or if it complains about
      "--force"; in the case it didn't complete, we retry the operation.
      
      We improve a bit the checking of "vgs", as it uses to fail silently
      and we didn't detect it.
      
      New tests for this function should test, I believe, all the expected
      variations; at the least we now have data files with the expected
      output.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      048eeb2b
  13. 06 Jan, 2012 1 commit
  14. 26 Sep, 2011 2 commits
  15. 23 Aug, 2011 1 commit
  16. 11 Aug, 2011 1 commit
  17. 12 Jul, 2010 1 commit
  18. 06 Jul, 2010 1 commit
  19. 30 Jun, 2010 1 commit
  20. 12 Mar, 2010 1 commit
  21. 21 Aug, 2009 1 commit
  22. 05 May, 2009 1 commit
    • Iustin Pop's avatar
      Fix compatibility with DRBD 8.3 · 01e2ce3a
      Iustin Pop authored
      DRBD 8.3 changes two more things compared to 8.2:
        - /proc/drbd format changed in multiple ways; the part we're
          interested is the ‘st:’ to ‘ro:‘ change (in the changelog named as
          “Renamed 'state' to 'role'”
        - “drbdsetup /dev/drbdN show” changed the ‘device’ stanza from:
            device "/dev/drbd0";
          to:
            device                  minor 0;
      
      This patch fixes these both and adds data files and unittests for DRBD
      8.3.1.
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      01e2ce3a
  23. 18 Jun, 2008 1 commit
    • Iustin Pop's avatar
      Rework the DRBD8 device status computation · 6b90c22e
      Iustin Pop authored
      Currently, compute the status of a drbd8 device in GetSyncStatus and
      return only the values that we need (and fit in the framework of
      GetSyncStatus). However, the full status details are useful (and needed)
      in other places, so the patch attempts to improve this situation.
      
      We abstract the status of a device outside in a separate class, that
      knows how to parse contents from /proc/drbd and set easily accessible
      attributes. We then simplify the GetSyncStatus to use this and return
      the values that it needs, and add a separate method that returns the
      full status object.
      
      The move to a separate class cleans up a little bit the old
      sync-progress computation from GetSyncStatus, but it's still many
      regexes.
      
      The patch also adds unittests for a few statuses, and modifies one
      BaseDRBD call to accept a custom filename instead of '/proc/drbd' to
      ease unittests.
      
      Reviewed-by: imsnah
      6b90c22e
  24. 07 Jan, 2008 1 commit
    • Iustin Pop's avatar
      Add unittest for DRBD8 drdbsetup show parser · 3840729d
      Iustin Pop authored
      This patch changes the bdev.DRBD8._GetDevInfo to take a string instead
      of a minor, separates the `drbdsetup show` invocation into a new
      separate method (bdev.DRBD8._GetShowData) and modifies the rest of the
      DRBD8 class to make the appropriate calls.
      
      It also adds a unittest script and data files for testing various cases
      of device output.
      
      Reviewed-by: imsnah
      3840729d