1. 08 Nov, 2012 3 commits
  2. 07 Nov, 2012 2 commits
    • Michael Hanselmann's avatar
      Add missing tests for commit f0d22861 · 7a70541e
      Michael Hanselmann authored
      Commit f0d22861 changed the logic of
      gnt_instance._ConvertNicDiskModifications to also allow a parameter
      named “modify”. Unfortunately the corresponding unittest was not
      updated. An “if”/“else” condition is also merged.
      Signed-off-by: default avatarMichael Hanselmann <hansmi@google.com>
      Reviewed-by: default avatarIustin Pop <iustin@google.com>
      7a70541e
    • Iustin Pop's avatar
      Fix compatibility with newer Haskell libraries · 1251817b
      Iustin Pop authored
      This small patch fixes compatibility with a few newer Haskell libraries:
      
      - base 4.6, included with ghc 7.6, removed the deprecated 'catch'
        function from Prelude, so our "import Prelude hiding (catch)" is now
        an error; we workaround by using fully-qualified
        Control.Exception.catch name
      
      - containers 0.5 changed the signature of 'deleteFindMax'; we
        workaround by using separate 'findMax' and 'deleteMax'
      
      - QuickCheck 2.5 removed the 'maxDiscards' test parameter, replacing
        it with a much better 'maxDiscardsRatio'; however, until we can
        depend on that, we workaround by just removing it (we don't control
        anymore the maxDiscards, instead leaving it default; for our default
        test size, this is no change, as the default value is already 500,
        which is our default as well) and not printing it anymore
      
      Tested on Squeeze (+extra libs), Wheezy and experimental, which covers
      all supported GHC versions.
      
      Also, merging this in master will be a pain, but unless we want to
      stop supporting 2.6…
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
      1251817b
  3. 06 Nov, 2012 4 commits
  4. 01 Nov, 2012 6 commits
  5. 30 Oct, 2012 5 commits
  6. 29 Oct, 2012 2 commits
  7. 26 Oct, 2012 1 commit
  8. 25 Oct, 2012 1 commit
  9. 19 Oct, 2012 1 commit
    • Iustin Pop's avatar
      Fix disk adoption interaction with ipolicy checks · ba147ff8
      Iustin Pop authored
      In Ganeti 2.6, disk adoption is broken due to the ipolicy checks being
      done before we read volume size from remote nodes. We fix this by
      simply moving these checks to after the disk adoption code which
      updates the disk size; it's not that nice that we fail a (almost)
      config-level check after we've reserved the LVs, etc., but we need to
      do so in order to validate the ipolicy correctly.
      
      Tested:
      
      - normal instance creation
      - creation via adoption with good size (pass)
      - creation via adoption with wrong LV size (fail as expected)
      - QA in progress
      Signed-off-by: default avatarIustin Pop <iustin@google.com>
      Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
      ba147ff8
  10. 17 Oct, 2012 1 commit
  11. 12 Oct, 2012 1 commit
  12. 11 Oct, 2012 1 commit
  13. 10 Oct, 2012 1 commit
  14. 05 Oct, 2012 2 commits
  15. 03 Oct, 2012 3 commits
  16. 01 Oct, 2012 1 commit
  17. 27 Sep, 2012 2 commits
  18. 12 Sep, 2012 3 commits