From fbe9022f32370e999aa52d827499dcae9f2e369e Mon Sep 17 00:00:00 2001
From: Guido Trotter <ultrotter@google.com>
Date: Tue, 8 Jul 2008 16:32:18 +0000
Subject: [PATCH] Convert LUTestDelay to concurrent usage
In order to do so:
- We set REQ_BGL to False
- We implement ExpandNames
That's it, really.
Reviewed-by: iustinp
---
lib/cmdlib.py | 19 ++++++++++++++-----
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index e7edabecd..a9f091c2c 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -4606,17 +4606,26 @@ class LUTestDelay(NoHooksLU):
"""
_OP_REQP = ["duration", "on_master", "on_nodes"]
+ REQ_BGL = False
- def CheckPrereq(self):
- """Check prerequisites.
+ def ExpandNames(self):
+ """Expand names and set required locks.
- This checks that we have a good list of nodes and/or the duration
- is valid.
+ This expands the node list, if any.
"""
-
+ self.needed_locks = {}
if self.op.on_nodes:
+ # _GetWantedNodes can be used here, but is not always appropriate to use
+ # this way in ExpandNames. Check LogicalUnit.ExpandNames docstring for
+ # more information.
self.op.on_nodes = _GetWantedNodes(self, self.op.on_nodes)
+ self.needed_locks[locking.LEVEL_NODE] = self.op.on_nodes
+
+ def CheckPrereq(self):
+ """Check prerequisites.
+
+ """
def Exec(self, feedback_fn):
"""Do the actual sleep.
--
GitLab