Commit f7661f6b authored by Iustin Pop's avatar Iustin Pop
Browse files

Cluster verify and N+1 warnings for offline nodes



Currently, cluster verify shows warnings N+1 warnings for offline
nodes having any redundant instances since the memory data that we
have for those nodes is zero, so any instance will trigger the
warning.

As the comment says, we already list secondary instances on offline
nodes, so that warning is enough, and we skip the N+1 one.
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarStephen Shirley <diamond@google.com>
parent c37bb2c6
......@@ -1622,6 +1622,12 @@ class LUClusterVerify(LogicalUnit):
# WARNING: we currently take into account down instances as well
# as up ones, considering that even if they're down someone
# might want to start them even in the event of a node failure.
if n_img.offline:
# we're skipping offline nodes from the N+1 warning, since
# most likely we don't have good memory infromation from them;
# we already list instances living on such nodes, and that's
# enough warning
continue
for prinode, instances in n_img.sbp.items():
needed_mem = 0
for instance in instances:
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment