From f6ffab5a753ef5c28f76afc21a9a386191f850ba Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Nussbaumer?= <rn@google.com> Date: Thu, 25 Nov 2010 15:00:04 +0100 Subject: [PATCH] Fix missed CheckArguments on ndparams for SetNodeParams MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the previous patch where I modified LUSetNodeParams to take ndparams into account I missed this additional check of parameters in the Logical Unit. This patch adds ndparams to the recognized parameter lists which has to be filled out if nothing else is. Signed-off-by: RenΓ© Nussbaumer <rn@google.com> Reviewed-by: Iustin Pop <iustin@google.com> --- lib/cmdlib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 21c49dc66..3f158b494 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -4039,7 +4039,7 @@ class LUSetNodeParams(LogicalUnit): self.op.node_name = _ExpandNodeName(self.cfg, self.op.node_name) all_mods = [self.op.offline, self.op.master_candidate, self.op.drained, self.op.master_capable, self.op.vm_capable, - self.op.secondary_ip] + self.op.secondary_ip, self.op.ndparams] if all_mods.count(None) == len(all_mods): raise errors.OpPrereqError("Please pass at least one modification", errors.ECODE_INVAL) -- GitLab