From f0583b667ef6f00d75efea95010b9c66510d2f97 Mon Sep 17 00:00:00 2001 From: Michele Tartara <mtartara@google.com> Date: Wed, 10 Apr 2013 14:36:44 +0000 Subject: [PATCH] Properly update iv_name of disks while changing templates Trasforming the disk of an instance from DRBD to plain did not properly update the iv_name of disks, leaving it to None. This commit modifies _ConvertDrbdToPlain to properly set the iv_name variables. An analogous fix is not required in the opposite function, _ConvertPlainToDrbd, because it uses _GenerateDiskTemplate, that already takes care of doing that. Fixes Issue 403. Signed-off-by: Michele Tartara <mtartara@google.com> Reviewed-by: Guido Trotter <ultrotter@google.com> --- lib/cmdlib.py | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 023084f74..5ad1338ad 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -14043,6 +14043,7 @@ class LUInstanceSetParams(LogicalUnit): # update instance structure instance.disks = new_disks instance.disk_template = constants.DT_PLAIN + _UpdateIvNames(0, instance.disks) self.cfg.Update(instance, feedback_fn) # Release locks in case removing disks takes a while -- GitLab