Commit edd8fe4c authored by René Nussbaumer's avatar René Nussbaumer
Browse files

Fix premature abort of LUOobCommand due to result.Raise



This is a bug I recognized while doing tests on gnt-node health. A left
over result.Raise line causes premature abort of LUOobCommand on the
first node failing the RPC call. This is not expected behaviour for
multiple nodes.

This bug is not critical for the current use case as for a single node
this just works as expected. Though for multi node this will fail,
that's the reason why QA and tests passed as currently we just had
single node invocation. QA for multi node will be included in the
gnt-node health, as this is the first command using multi node.
Signed-off-by: default avatarRené Nussbaumer <rn@google.com>
Reviewed-by: default avatarIustin Pop <iustin@google.com>
parent 5f074973
......@@ -3244,8 +3244,6 @@ class LUOobCommand(NoHooksLU):
self.op.command, node.name,
self.op.timeout)
result.Raise("An error occurred on execution of OOB helper")
if result.fail_msg:
self.LogWarning("On node '%s' out-of-band RPC failed with: %s",
node.name, result.fail_msg)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment