From ea5a5b744b177eb433d2915524f258e6615b95bd Mon Sep 17 00:00:00 2001
From: Guido Trotter <ultrotter@google.com>
Date: Fri, 13 Feb 2009 12:28:14 +0000
Subject: [PATCH] Remove two fixed FIXME and convert one to TODO
The cli FIXME is not something broken, but rather some better handling
feature we'd rather have, and the two backend FIXME are done (disks have
their read only parameter set, and the error is raised and thus reaches
the master).
Reviewed-by: iustinp
---
lib/backend.py | 2 --
lib/cli.py | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/backend.py b/lib/backend.py
index 1c9cfdbaa..b3e3f49e9 100644
--- a/lib/backend.py
+++ b/lib/backend.py
@@ -575,7 +575,6 @@ def GetInstanceList(hypervisor_list):
results.extend(names)
except errors.HypervisorError, err:
logging.exception("Error enumerating instances for hypevisor %s", hname)
- # FIXME: should we somehow not propagate this to the master?
raise
return results
@@ -1666,7 +1665,6 @@ def OSEnvironment(instance, debug=0):
str(disk))
real_disk.Open()
result['DISK_%d_PATH' % idx] = real_disk.dev_path
- # FIXME: When disks will have read-only mode, populate this
result['DISK_%d_ACCESS' % idx] = disk.mode
if constants.HV_DISK_TYPE in instance.hvparams:
result['DISK_%d_FRONTEND_TYPE' % idx] = \
diff --git a/lib/cli.py b/lib/cli.py
index 0d5a5db15..124f602ed 100644
--- a/lib/cli.py
+++ b/lib/cli.py
@@ -797,7 +797,7 @@ def GenerateTable(headers, fields, separator, data,
format_fields = []
for field in fields:
if headers and field not in headers:
- # FIXME: handle better unknown fields (either revert to old
+ # TODO: handle better unknown fields (either revert to old
# style of raising exception, or deal more intelligently with
# variable fields)
headers[field] = field
--
GitLab