From ea33068f0eedca29562da6962477155bd71b60d8 Mon Sep 17 00:00:00 2001
From: Iustin Pop <iustin@google.com>
Date: Tue, 13 Jan 2009 14:43:12 +0000
Subject: [PATCH] Fix modification of instance memory
... as found by the QA script - bug was introduced by me in commit 2117.
Reviwed-by: imsnah
---
lib/cmdlib.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index 4cad9bd0c..0414dc497 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -5286,7 +5286,9 @@ class LUSetInstanceParams(LogicalUnit):
" missing on its primary node" % miss_mem)
if be_new[constants.BE_AUTO_BALANCE]:
- for node, nres in instance.secondary_nodes.iteritems():
+ for node, nres in nodeinfo.iteritems():
+ if node not in instance.secondary_nodes:
+ continue
if nres.failed or not isinstance(nres.data, dict):
self.warn.append("Can't get info from secondary node %s" % node)
elif be_new[constants.BE_MEMORY] > nres.data['memory_free']:
--
GitLab