Commit e6e4ff4c authored by Michele Tartara's avatar Michele Tartara
Browse files

Change usb_devices separator to whitespace



The usb_devices parameter was using comma as a list separator, but this cannot
work because comma is already used as the hypervisor parameter separator.

Change it to use whitespace as a separator, in accordance to what already done
for the extra parameters.

The NEWS file is updated accordingly.

Fixes Issue 649.
Signed-off-by: default avatarMichele Tartara <mtartara@google.com>
Reviewed-by: default avatarHelga Velroyen <helgav@google.com>
parent 7bc2c097
...@@ -2,6 +2,16 @@ News ...@@ -2,6 +2,16 @@ News
==== ====
Version 2.8.4
-------------
*(unreleased)*
- Change the list separator for the usb_devices parameter from comma to space.
Commas could not work because they are already the hypervisor option
separator (Issue 649)
Version 2.8.3 Version 2.8.3
------------- -------------
......
...@@ -1384,7 +1384,7 @@ class KVMHypervisor(hv_base.BaseHypervisor): ...@@ -1384,7 +1384,7 @@ class KVMHypervisor(hv_base.BaseHypervisor):
# Various types of usb devices, comma separated # Various types of usb devices, comma separated
if hvp[constants.HV_USB_DEVICES]: if hvp[constants.HV_USB_DEVICES]:
for dev in hvp[constants.HV_USB_DEVICES].split(","): for dev in hvp[constants.HV_USB_DEVICES].split(" "):
kvm_cmd.extend(["-usbdevice", dev]) kvm_cmd.extend(["-usbdevice", dev])
if hvp[constants.HV_KVM_EXTRA]: if hvp[constants.HV_KVM_EXTRA]:
......
...@@ -723,10 +723,12 @@ soundhw ...@@ -723,10 +723,12 @@ soundhw
usb\_devices usb\_devices
Valid for the KVM hypervisor. Valid for the KVM hypervisor.
Comma separated list of usb devices. These can be emulated devices Space separated list of usb devices. These can be emulated devices
or passthrough ones, and each one gets passed to kvm with its own or passthrough ones, and each one gets passed to kvm with its own
``-usbdevice`` option. See the **qemu**\(1) manpage for the syntax ``-usbdevice`` option. See the **qemu**\(1) manpage for the syntax
of the possible components. of the possible components. Note that values set with this
parameter are split on a space character and currently don't support
quoting.
vga vga
Valid for the KVM hypervisor. Valid for the KVM hypervisor.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment