From e233490013e62eaf2e702ce8b38adeb411983fb7 Mon Sep 17 00:00:00 2001 From: Iustin Pop <iustin@google.com> Date: Thu, 18 Nov 2010 10:20:06 +0100 Subject: [PATCH] Fix breakage in OS state modify MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I was using the feedback_fn function incorrectly (it doesn't automatically expand the arguments). Signed-off-by: Iustin Pop <iustin@google.com> Reviewed-by: RenΓ© Nussbaumer <rn@google.com> --- lib/cmdlib.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index a10aba72e..6393cce0e 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -2882,14 +2882,14 @@ class LUSetClusterParams(LogicalUnit): for key, val in mods: if key == constants.DDM_ADD: if val in lst: - feedback_fn("OS %s already in %s, ignoring", val, desc) + feedback_fn("OS %s already in %s, ignoring" % (val, desc)) else: lst.append(val) elif key == constants.DDM_REMOVE: if val in lst: lst.remove(val) else: - feedback_fn("OS %s not found in %s, ignoring", val, desc) + feedback_fn("OS %s not found in %s, ignoring" % (val, desc)) else: raise errors.ProgrammerError("Invalid modification '%s'" % key) -- GitLab