diff --git a/lib/confd/client.py b/lib/confd/client.py index 674a2ca394b85b3027c9e82e54da3e32653ccede..e2d1a8bd1b416bb6d2fc4f2b64dd6af414995b8e 100644 --- a/lib/confd/client.py +++ b/lib/confd/client.py @@ -130,6 +130,8 @@ class ConfdClient: @param peers: list of peer nodes """ + # we are actually called from init, so: + # pylint: disable-msg=W0201 if not isinstance(peers, list): raise errors.ProgrammerError("peers must be a list") self._peers = peers diff --git a/lib/objects.py b/lib/objects.py index f8d94da42a2ee39097c8323a7c1c6ba2d417fb9a..314606d3a6210da7c049f4a6b795caf0c71df3df 100644 --- a/lib/objects.py +++ b/lib/objects.py @@ -48,7 +48,7 @@ __all__ = ["ConfigObject", "ConfigData", "NIC", "Disk", "Instance", _TIMESTAMPS = ["ctime", "mtime"] _UUID = ["uuid"] -def FillDict(defaults_dict, custom_dict, skip_keys=[]): +def FillDict(defaults_dict, custom_dict, skip_keys=None): """Basic function to apply settings on top a default dict. @type defaults_dict: dict @@ -63,11 +63,12 @@ def FillDict(defaults_dict, custom_dict, skip_keys=[]): """ ret_dict = copy.deepcopy(defaults_dict) ret_dict.update(custom_dict) - for k in skip_keys: - try: - del ret_dict[k] - except KeyError: - pass + if skip_keys: + for k in skip_keys: + try: + del ret_dict[k] + except KeyError: + pass return ret_dict diff --git a/lib/rapi/connector.py b/lib/rapi/connector.py index bc9bb8cf62f57e79e522d8453487710c3353b029..3ef842bac2e49702087617e309e7c88132734b6f 100644 --- a/lib/rapi/connector.py +++ b/lib/rapi/connector.py @@ -46,12 +46,14 @@ class Mapper: """Map resource to method. """ - def __init__(self, connector=CONNECTOR): + def __init__(self, connector=None): """Resource mapper constructor. @param connector: a dictionary, mapping method name with URL path regexp """ + if connector is None: + connector = CONNECTOR self._connector = connector def getController(self, uri):