From d489ca4f630b823291e01a00f4d5e140e219eaa3 Mon Sep 17 00:00:00 2001 From: Guido Trotter <ultrotter@google.com> Date: Thu, 26 Jun 2008 14:42:44 +0000 Subject: [PATCH] When removing a node don't ssh to it Even in 1.2 this behaviour is broken, as the rpc call will remove the ssh keys before we get a chance to log in. Now the rpc takes care of shutting down the node daemon as well, so we definitely can avoid this. This makes the LURemoveNode operation work again with the threaded master daemon. Reviewed-by: iustinp --- lib/cmdlib.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index c1f08129f..1c6db1cb1 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -1241,8 +1241,6 @@ class LURemoveNode(LogicalUnit): rpc.call_node_leave_cluster(node.name) - self.ssh.Run(node.name, 'root', "%s stop" % constants.NODE_INITD_SCRIPT) - logger.Info("Removing node %s from config" % node.name) self.cfg.RemoveNode(node.name) -- GitLab