diff --git a/qa/qa_instance.py b/qa/qa_instance.py index 5303f255a7a32ab9dd2ba8257f44f946e6f1ec7e..0ea9f2b2c42592f867c179530c36cb2921236c09 100644 --- a/qa/qa_instance.py +++ b/qa/qa_instance.py @@ -259,6 +259,8 @@ def TestInstanceInfo(instance): @InstanceCheck(INST_UP, INST_UP, FIRST_ARG) def TestInstanceModify(instance): """gnt-instance modify""" + default_hv = qa_config.GetDefaultHypervisor() + # Assume /sbin/init exists on all systems test_kernel = "/sbin/init" test_initrd = test_kernel @@ -266,6 +268,7 @@ def TestInstanceModify(instance): orig_maxmem = qa_config.get(constants.BE_MAXMEM) orig_minmem = qa_config.get(constants.BE_MINMEM) #orig_bridge = qa_config.get("bridge", "xen-br0") + args = [ ["-B", "%s=128" % constants.BE_MINMEM], ["-B", "%s=128" % constants.BE_MAXMEM], @@ -279,18 +282,24 @@ def TestInstanceModify(instance): ["-H", "%s=%s" % (constants.HV_KERNEL_PATH, test_kernel)], ["-H", "%s=%s" % (constants.HV_KERNEL_PATH, constants.VALUE_DEFAULT)], - ["-H", "%s=%s" % (constants.HV_INITRD_PATH, test_initrd)], - ["-H", "no_%s" % (constants.HV_INITRD_PATH, )], - ["-H", "%s=%s" % (constants.HV_INITRD_PATH, constants.VALUE_DEFAULT)], # TODO: bridge tests #["--bridge", "xen-br1"], #["--bridge", orig_bridge], - - # TODO: Do these tests only with xen-hvm - #["-H", "%s=acn" % constants.HV_BOOT_ORDER], - #["-H", "%s=%s" % (constants.HV_BOOT_ORDER, constants.VALUE_DEFAULT)], ] + + if default_hv == constants.HT_XEN_PVM: + args.extend([ + ["-H", "%s=%s" % (constants.HV_INITRD_PATH, test_initrd)], + ["-H", "no_%s" % (constants.HV_INITRD_PATH, )], + ["-H", "%s=%s" % (constants.HV_INITRD_PATH, constants.VALUE_DEFAULT)], + ]) + elif default_hv == constants.HT_XEN_HVM: + args.extend([ + ["-H", "%s=acn" % constants.HV_BOOT_ORDER], + ["-H", "%s=%s" % (constants.HV_BOOT_ORDER, constants.VALUE_DEFAULT)], + ]) + for alist in args: AssertCommand(["gnt-instance", "modify"] + alist + [instance["name"]])