From d2d66df02279b469ab6a2f9652a943aabcfc11c0 Mon Sep 17 00:00:00 2001
From: Klaus Aehlig <aehlig@google.com>
Date: Mon, 22 Apr 2013 11:08:29 +0200
Subject: [PATCH] devel/review: fix addition of reviewer from environment
In commit 3dd990, the possibility of taking a default reviewer
from the environment was introduced. Fix two deficits here
- perl does not inherit the environment
- add at all places.
Signed-off-by: Klaus Aehlig <aehlig@google.com>
Reviewed-by: Guido Trotter <ultrotter@google.com>
---
devel/review | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/devel/review b/devel/review
index e2ddd6299..d3f6594b5 100755
--- a/devel/review
+++ b/devel/review
@@ -38,13 +38,15 @@ add_reviewed_by() {
grep -q '^Reviewed-by: ' "$msgfile" && return
perl -i -e '
+ my $reviewer = $ENV{"REVIEWER"};
+ defined($reviewer) or $reviewer = "";
my $sob = 0;
while (<>) {
if ($sob == 0 and m/^Signed-off-by:/) {
$sob = 1;
} elsif ($sob == 1 and not m/^Signed-off-by:/) {
- print "Reviewed-by: $REVIEWER\n";
+ print "Reviewed-by: $reviewer\n";
$sob = -1;
}
@@ -52,7 +54,7 @@ add_reviewed_by() {
}
if ($sob == 1) {
- print "Reviewed-by: \n";
+ print "Reviewed-by: $reviewer\n";
}
' "$msgfile"
}
--
GitLab