diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 399aca4bb3b831fd4665776d7db3aadc5d4b47ee..46d4eaee6c9641deaf0601f113f2319ddf089c88 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -2620,12 +2620,12 @@ class LUSetClusterParams(LogicalUnit): ("drbd_helper", None, _TOr(_TString, _TNone)), ("default_iallocator", None, _TMaybeString), ("reserved_lvs", None, _TOr(_TListOf(_TNonEmptyString), _TNone)), - ("hidden_oss", None, _TOr(_TListOf(\ + ("hidden_os", None, _TOr(_TListOf(\ _TAnd(_TList, _TIsLength(2), _TMap(lambda v: v[0], _TElemOf(constants.DDMS_VALUES)))), _TNone)), - ("blacklisted_oss", None, _TOr(_TListOf(\ + ("blacklisted_os", None, _TOr(_TListOf(\ _TAnd(_TList, _TIsLength(2), _TMap(lambda v: v[0], _TElemOf(constants.DDMS_VALUES)))), @@ -2903,7 +2903,8 @@ class LUSetClusterParams(LogicalUnit): if self.op.reserved_lvs is not None: self.cluster.reserved_lvs = self.op.reserved_lvs - def helper_oss(aname, mods, desc): + def helper_os(aname, mods, desc): + desc += " OS list" lst = getattr(self.cluster, aname) for key, val in mods: if key == constants.DDM_ADD: @@ -2919,13 +2920,11 @@ class LUSetClusterParams(LogicalUnit): else: raise errors.ProgrammerError("Invalid modification '%s'" % key) - if self.op.hidden_oss: - helper_oss("hidden_oss", self.op.hidden_oss, - "hidden OS list") + if self.op.hidden_os: + helper_os("hidden_os", self.op.hidden_os, "hidden") - if self.op.blacklisted_oss: - helper_oss("blacklisted_oss", self.op.blacklisted_oss, - "blacklisted OS list") + if self.op.blacklisted_os: + helper_os("blacklisted_os", self.op.blacklisted_os, "blacklisted") self.cfg.Update(self.cluster, feedback_fn) @@ -3209,8 +3208,8 @@ class LUDiagnoseOS(NoHooksLU): params.intersection_update(node_params) api_versions.intersection_update(node_api) - is_hid = os_name in cluster.hidden_oss - is_blk = os_name in cluster.blacklisted_oss + is_hid = os_name in cluster.hidden_os + is_blk = os_name in cluster.blacklisted_os if ((self._HID not in self.op.output_fields and is_hid) or (self._BLK not in self.op.output_fields and is_blk) or (self._VLD not in self.op.output_fields and not valid)): @@ -6702,7 +6701,7 @@ class LUCreateInstance(LogicalUnit): if self.op.os_type is None: raise errors.OpPrereqError("No guest OS specified", errors.ECODE_INVAL) - if self.op.os_type in self.cfg.GetClusterInfo().blacklisted_oss: + if self.op.os_type in self.cfg.GetClusterInfo().blacklisted_os: raise errors.OpPrereqError("Guest OS '%s' is not allowed for" " installation" % self.op.os_type, errors.ECODE_STATE) diff --git a/lib/objects.py b/lib/objects.py index 827f680dec9bbafaf5592ea9e40f90bb5d21d52b..612198a714335d6dec084e4aaf3cfe64bdfd91ea 100644 --- a/lib/objects.py +++ b/lib/objects.py @@ -1003,9 +1003,9 @@ class Cluster(TaggableObject): "maintain_node_health", "uid_pool", "default_iallocator", + "hidden_os", + "blacklisted_os", "primary_ip_family", - "hidden_oss", - "blacklisted_oss", ] + _TIMESTAMPS + _UUID def UpgradeConfig(self): @@ -1072,11 +1072,11 @@ class Cluster(TaggableObject): self.reserved_lvs = [] # hidden and blacklisted operating systems added before 2.2.1 - if self.hidden_oss is None: - self.hidden_oss = [] + if self.hidden_os is None: + self.hidden_os = [] - if self.blacklisted_oss is None: - self.blacklisted_oss = [] + if self.blacklisted_os is None: + self.blacklisted_os = [] # primary_ip_family added before 2.3 if self.primary_ip_family is None: diff --git a/lib/opcodes.py b/lib/opcodes.py index d314fc8a915f9b552c67582b9aa69a6476423475..f9c002ad0ab86edd87a6c048976ff760073c18c9 100644 --- a/lib/opcodes.py +++ b/lib/opcodes.py @@ -316,8 +316,8 @@ class OpSetClusterParams(OpCode): "remove_uids", "default_iallocator", "reserved_lvs", - "hidden_oss", - "blacklisted_oss", + "hidden_os", + "blacklisted_os", ] diff --git a/scripts/gnt-os b/scripts/gnt-os index 48d6e3003b3182da1a0b7590d2ff2852f5c1edb7..f74213a100bb959425917b54dad9b010b6d48ae7 100755 --- a/scripts/gnt-os +++ b/scripts/gnt-os @@ -273,8 +273,8 @@ def ModifyOS(opts, args): op = opcodes.OpSetClusterParams(os_hvp=os_hvp, osparams=osp, - hidden_oss=ohid, - blacklisted_oss=oblk) + hidden_os=ohid, + blacklisted_os=oblk) SubmitOpCode(op, opts=opts) return 0