From ccedb11b63e2612e4b2bfa4b0d57f41a2aefd8da Mon Sep 17 00:00:00 2001
From: Michael Hanselmann <hansmi@google.com>
Date: Sat, 17 Jul 2010 22:56:18 +0200
Subject: [PATCH] workerpool: Remove unused worker method
HasRunningTask is never used except for an assertion, where we
don't really need the lock.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
---
lib/workerpool.py | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/lib/workerpool.py b/lib/workerpool.py
index 25f31b4ab..16e713f05 100644
--- a/lib/workerpool.py
+++ b/lib/workerpool.py
@@ -63,16 +63,6 @@ class BaseWorker(threading.Thread, object):
"""
return (self._current_task is not None)
- def HasRunningTask(self):
- """Returns whether this worker is currently running a task.
-
- """
- self.pool._lock.acquire()
- try:
- return self._HasRunningTaskUnlocked()
- finally:
- self.pool._lock.release()
-
def run(self):
"""Main thread function.
@@ -81,7 +71,7 @@ class BaseWorker(threading.Thread, object):
"""
pool = self.pool
- assert not self.HasRunningTask()
+ assert self._current_task is None
while True:
try:
--
GitLab