Commit c6f1af07 authored by Iustin Pop's avatar Iustin Pop
Browse files

Fix another style issue

For the Nth time, re-fix shadowing of outer-scope variable :)
Signed-off-by: default avatarIustin Pop <>
Reviewed-by: default avatarMichael Hanselmann <>
parent dc09c3cf
......@@ -722,23 +722,23 @@ def _CheckInstanceBridgesExist(lu, instance, node=None):
_CheckNicsBridgesExist(lu, instance.nics, node)
def _CheckOSVariant(os, name):
def _CheckOSVariant(os_obj, name):
"""Check whether an OS name conforms to the os variants specification.
@type os: L{objects.OS}
@param os: OS object to check
@type os_obj: L{objects.OS}
@param os_obj: OS object to check
@type name: string
@param name: OS name passed by the user, to check for validity
if not os.supported_variants:
if not os_obj.supported_variants:
variant = name.split("+", 1)[1]
except IndexError:
raise errors.OpPrereqError("OS name must include a variant")
if variant not in os.supported_variants:
if variant not in os_obj.supported_variants:
raise errors.OpPrereqError("Unsupported OS variant")
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment