From b5602d15cb500f8e5adc82563428fbea739e01e3 Mon Sep 17 00:00:00 2001 From: Guido Trotter <ultrotter@google.com> Date: Fri, 27 Jun 2008 14:28:06 +0000 Subject: [PATCH] LUAddNode: upload files via rpc, not scp We used to scp all the ssconf files, and the vnc password file to the new node. With this patch we use the upload_file rpc, specifying just the new node as a destination. All the files previously copied by scp are already allowed by the backend. Reviewed-by: iustinp --- lib/cmdlib.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 30028af70..e3c1a8624 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -1643,7 +1643,8 @@ class LUAddNode(LogicalUnit): if self.sstore.GetHypervisorType() == constants.HT_XEN_HVM31: to_copy.append(constants.VNC_PASSWORD_FILE) for fname in to_copy: - if not self.ssh.CopyFileToNode(node, fname): + result = rpc.call_upload_file([node], fname) + if not result[node]: logger.Error("could not copy file %s to node %s" % (fname, node)) if not self.op.readd: -- GitLab