Commit b47587b0 authored by Niklas Hambuechen's avatar Niklas Hambuechen
Browse files

qa_utils: Make AssertCommand return stdout/stderr as well

This is usefull if the run commands output something that's needed afterwards.
Signed-off-by: default avatarNiklas Hambuechen <>
Reviewed-by: default avatarKlaus Aehlig <>
parent 513673d0
......@@ -167,7 +167,7 @@ def AssertCommand(cmd, fail=False, node=None, log_cmd=True, max_seconds=None):
@type max_seconds: double
@param max_seconds: fail if the command takes more than C{max_seconds}
@return: the return code of the command
@return: the return code, stdout and stderr of the command
@raise qa_error.Error: if the command fails when it shouldn't or vice versa
......@@ -182,7 +182,10 @@ def AssertCommand(cmd, fail=False, node=None, log_cmd=True, max_seconds=None):
cmdstr = utils.ShellQuoteArgs(cmd)
start =
rcode = StartSSH(nodename, cmdstr, log_cmd=log_cmd).wait()
popen = StartSSH(nodename, cmdstr, log_cmd=log_cmd)
# Run the command
stdout, stderr = popen.communicate()
rcode = popen.returncode
duration_seconds = TimedeltaToTotalSeconds( - start)
_AssertRetCode(rcode, fail, cmdstr, nodename)
......@@ -192,7 +195,7 @@ def AssertCommand(cmd, fail=False, node=None, log_cmd=True, max_seconds=None):
"Cmd '%s' took %f seconds, maximum of %f was exceeded" %
(cmdstr, duration_seconds, max_seconds))
return rcode
return rcode, stdout, stderr
def AssertRedirectedCommand(cmd, fail=False, node=None, log_cmd=True):
......@@ -298,7 +301,8 @@ def StartSSH(node, cmd, strict=True, log_cmd=True):
return StartLocalCommand(GetSSHCommand(node, cmd, strict=strict),
_nolog_opts=True, log_cmd=log_cmd)
_nolog_opts=True, log_cmd=log_cmd,
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
def StartMultiplexer(node):
......@@ -572,10 +576,10 @@ def GenericQueryTest(cmd, fields, namefield="name", test_unknown=True):
# Check exit code for listing unknown field
AssertEqual(AssertRedirectedCommand([cmd, "list",
rcode, _, _ = AssertRedirectedCommand([cmd, "list",
AssertEqual(rcode, constants.EXIT_UNKNOWN_FIELD)
def GenericQueryFieldsTest(cmd, fields):
......@@ -593,9 +597,9 @@ def GenericQueryFieldsTest(cmd, fields):
# Check exit code for listing unknown field
AssertEqual(AssertCommand([cmd, "list-fields", "field/does/not/exist"],
rcode, _, _ = AssertCommand([cmd, "list-fields", "field/does/not/exist"],
AssertEqual(rcode, constants.EXIT_UNKNOWN_FIELD)
def AddToEtcHosts(hostnames):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment