Commit a3a19a06 authored by Jose A. Lopes's avatar Jose A. Lopes

Remove unused functions to check OS variants

... as this is now performed on the node.
Signed-off-by: default avatarJose A. Lopes <>
Reviewed-by: default avatarPetr Pudlak <>
parent 0bb2a91f
......@@ -539,45 +539,3 @@ def CheckNicsBridgesExist(lu, nics, node_uuid):
result.Raise("Error checking bridges on destination node '%s'" %
lu.cfg.GetNodeName(node_uuid), prereq=True,
def CheckNodeHasOS(lu, node_uuid, os_name, force_variant):
"""Ensure that a node supports a given OS.
@param lu: the LU on behalf of which we make the check
@param node_uuid: the node to check
@param os_name: the OS to query about
@param force_variant: whether to ignore variant errors
@raise errors.OpPrereqError: if the node is not supporting the OS
result = lu.rpc.call_os_get(node_uuid, os_name)
result.Raise("OS '%s' not in supported OS list for node %s" %
(os_name, lu.cfg.GetNodeName(node_uuid)),
prereq=True, ecode=errors.ECODE_INVAL)
if not force_variant:
_CheckOSVariant(result.payload, os_name)
def _CheckOSVariant(os_obj, name):
"""Check whether an OS name conforms to the os variants specification.
@type os_obj: L{objects.OS}
@param os_obj: OS object to check
@type name: string
@param name: OS name passed by the user, to check for validity
variant = objects.OS.GetVariant(name)
if not os_obj.supported_variants:
if variant:
raise errors.OpPrereqError("OS '%s' doesn't support variants ('%s'"
" passed)" % (, variant),
if not variant:
raise errors.OpPrereqError("OS name must include a variant",
if variant not in os_obj.supported_variants:
raise errors.OpPrereqError("Unsupported OS variant", errors.ECODE_INVAL)
Markdown is supported
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment