From 9fa08c841db0c49fddc366d772fba1c661f43578 Mon Sep 17 00:00:00 2001 From: Michael Hanselmann <hansmi@google.com> Date: Fri, 23 Nov 2012 04:39:20 +0100 Subject: [PATCH] LUClusterVerifyGroup: Use node allocation lock See comment in code. Signed-off-by: Michael Hanselmann <hansmi@google.com> Reviewed-by: Helga Velroyen <helgav@google.com> --- lib/cmdlib.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/cmdlib.py b/lib/cmdlib.py index 253a7038a..92b881df7 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -2233,6 +2233,11 @@ class LUClusterVerifyGroup(LogicalUnit, _VerifyErrors): locking.LEVEL_INSTANCE: inst_names, locking.LEVEL_NODEGROUP: [self.group_uuid], locking.LEVEL_NODE: [], + + # This opcode is run by watcher every five minutes and acquires all nodes + # for a group. It doesn't run for a long time, so it's better to acquire + # the node allocation lock as well. + locking.LEVEL_NODE_ALLOC: locking.ALL_SET, } self.share_locks = _ShareAll() -- GitLab