Commit 9f7b4967 authored by Guido Trotter's avatar Guido Trotter
Browse files

Don't lock on QueryJobs, by using the disk version

We move from querying the in-memory version to loading all jobs from the
disk. Since the jobs are written/deleted on disk in an atomic manner, we
don't need to lock at all. Also, since we're just looking at the
contents of a directory, we don't need to check that the job queue is

If some jobs are removed between when we listed them and us loading
them, we need to be able to cope: if we were asked to load those jobs
specifically, we must report the failure, but if we were just asked to
"load all" we shall just not consider them as part of the "all" set,
since they were deleted.
Signed-off-by: default avatarGuido Trotter <>
Reviewed-by: default avatarIustin Pop <>
parent 0f9c08dc
......@@ -1031,21 +1031,6 @@ class JobQueue(object):
return job
def _GetJobsUnlocked(self, job_ids):
"""Return a list of jobs based on their IDs.
@type job_ids: list
@param job_ids: either an empty list (meaning all jobs),
or a list of job IDs
@rtype: list
@return: the list of job objects
if not job_ids:
job_ids = self._GetJobIDsUnlocked()
return [self._LoadJobUnlocked(job_id) for job_id in job_ids]
def SafeLoadJobFromDisk(self, job_id):
"""Load the given job file from disk.
......@@ -1426,14 +1411,9 @@ class JobQueue(object):
return (archived_count, len(all_job_ids) - last_touched)
def QueryJobs(self, job_ids, fields):
"""Returns a list of jobs in queue.
This is a wrapper of L{_GetJobsUnlocked}, which actually does the
processing for each job.
@type job_ids: list
@param job_ids: sequence of job identifiers or None for all
@type fields: list
......@@ -1444,12 +1424,19 @@ class JobQueue(object):
jobs = []
list_all = False
if not job_ids:
# Since files are added to/removed from the queue atomically, there's no
# risk of getting the job ids in an inconsistent state.
job_ids = self._GetJobIDsUnlocked()
list_all = True
for job in self._GetJobsUnlocked(job_ids):
if job is None:
for job_id in job_ids:
job = self.SafeLoadJobFromDisk(job_id)
if job is not None:
elif not list_all:
return jobs
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment