Commit 9cda4d6a authored by Iustin Pop's avatar Iustin Pop
Browse files

Fix long lines in Ganeti.HTools.Types and add Make check



Since hlint doesn't check style issues but rather code only issues,
let's add a simple Makefile check for too-long lines, and fix the
single bad case we have currently.
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarGuido Trotter <ultrotter@google.com>
parent a2d7ea09
......@@ -1476,9 +1476,14 @@ check-local: check-dirs $(GENERATED_FILES)
echo "File $(top_srcdir)/doc/design-$$expver.rst not found"; \
exit 1; \
fi; \
if test $$(wc --max-line-length < $(top_srcdir)/configure.ac) -gt 80; then \
echo 'Longest line in configure.ac is longer than 80 characters' >&2; \
fi
error= ; \
for file in configure.ac $(HS_LIBTEST_SRCS) $(HS_PROG_SRCS); do \
if test $$(wc --max-line-length < $(top_srcdir)/$$file) -gt 80; then \
echo "Longest line in $$file is longer than 80 characters" >&2; \
error=1; \
fi; \
done; \
test -z "$$error"
.PHONY: hs-check
hs-check: htest/test htest/hpc-htools $(HS_BUILT_TEST_HELPERS)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment