From 8a3fe350374465fed5dac8d64401e2ff04fda6fd Mon Sep 17 00:00:00 2001
From: Guido Trotter <ultrotter@google.com>
Date: Wed, 30 Apr 2008 09:29:21 +0000
Subject: [PATCH] LogicalUnit.BuildHooksEnv, update docstring
The LogicalUnit.BuildHooksEnv docstring used to say that the node list should
not include the master node. This is obviously not the case checking the
relevant code, and double-checking with iustin he confirmed it just document
some obsolete behaviour. This patch removes those remarks making the docstring
shorter, easier, and, last but not least, correct! ;)
Reviewed-by: iustinp
---
lib/cmdlib.py | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index 033080da3..760f7d70d 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -145,11 +145,7 @@ class LogicalUnit(object):
added by the hooks runner. If the LU doesn't define any
environment, an empty dict (and not None) should be returned.
- As for the node lists, the master should not be included in the
- them, as it will be added by the hooks runner in case this LU
- requires a cluster to run on (otherwise we don't have a node
- list). No nodes should be returned as an empty list (and not
- None).
+ No nodes should be returned as an empty list (and not None).
Note that if the HPATH for a LU class is None, this function will
not be called.
--
GitLab