Commit 889bed16 authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

qa_utils: Factorize code for getting entity name

This reduces code duplication and provides better error messages if
something is incorrect while getting a node or instance name.
Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarIustin Pop <>
parent 1a4e4b17
......@@ -133,6 +133,28 @@ def AssertMatch(string, pattern):
raise qa_error.Error("%r doesn't match /%r/" % (string, pattern))
def _GetName(entity, key):
"""Tries to get name of an entity.
@type entity: string or dict
@type key: string
@param key: Dictionary key containing name
if isinstance(entity, basestring):
result = entity
elif isinstance(entity, dict):
result = entity[key]
raise qa_error.Error("Expected string or dictionary, got %s: %s" %
(type(entity), entity))
if not ht.TNonEmptyString(result):
raise Exception("Invalid name '%s'" % result)
return result
def AssertCommand(cmd, fail=False, node=None):
"""Checks that a remote command succeeds.
......@@ -148,10 +170,7 @@ def AssertCommand(cmd, fail=False, node=None):
if node is None:
node = qa_config.GetMasterNode()
if isinstance(node, basestring):
nodename = node
nodename = node["primary"]
nodename = _GetName(node, "primary")
if isinstance(cmd, basestring):
cmdstr = cmd
......@@ -544,13 +563,7 @@ def RunInstanceCheck(instance, running):
"""Check if instance is running or not.
if isinstance(instance, basestring):
instance_name = instance
instance_name = instance["name"]
if not ht.TNonEmptyString(instance_name):
raise Exception("Invalid instance name '%s'" % instance_name)
instance_name = _GetName(instance, "name")
script = qa_config.GetInstanceCheckScript()
if not script:
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment