diff --git a/lib/rapi/rlib2.py b/lib/rapi/rlib2.py index ace53cfb0cdb6ee60df13912eecf547d7db2a7e7..6827fe59bbfa4135f99d77f6d24f6b242994ecf2 100644 --- a/lib/rapi/rlib2.py +++ b/lib/rapi/rlib2.py @@ -665,24 +665,23 @@ class R_2_groups_name_rename(baserlib.OpcodeResource): }) -class R_2_groups_name_assign_nodes(baserlib.ResourceBase): +class R_2_groups_name_assign_nodes(baserlib.OpcodeResource): """/2/groups/[group_name]/assign-nodes resource. """ - def PUT(self): - """Assigns nodes to a group. + PUT_OPCODE = opcodes.OpGroupAssignNodes - @return: a job id + def GetPutOpInput(self): + """Assigns nodes to a group. """ - op = baserlib.FillOpcode(opcodes.OpGroupAssignNodes, self.request_body, { + assert len(self.items) == 1 + return (self.request_body, { "group_name": self.items[0], "dry_run": self.dryRun(), "force": self.useForce(), }) - return self.SubmitJob([op]) - def _ParseInstanceCreateRequestVersion1(data, dry_run): """Parses an instance creation request version 1. diff --git a/test/ganeti.rapi.rlib2_unittest.py b/test/ganeti.rapi.rlib2_unittest.py index 195fe03b304d874059b83b8c3f4f294217e78ebd..649fa824db9cfcf5df18c49c871919c8c0ab5312 100755 --- a/test/ganeti.rapi.rlib2_unittest.py +++ b/test/ganeti.rapi.rlib2_unittest.py @@ -272,6 +272,31 @@ class TestNodeEvacuate(unittest.TestCase): self.assertRaises(IndexError, cl.GetNextSubmittedJob) +class TestGroupAssignNodes(unittest.TestCase): + def test(self): + clfactory = _FakeClientFactory(_FakeClient) + handler = _CreateHandler(rlib2.R_2_groups_name_assign_nodes, ["grp-a"], { + "dry-run": ["1"], + "force": ["1"], + }, { + "nodes": ["n2", "n3"], + }, clfactory) + job_id = handler.PUT() + + cl = clfactory.GetNextClient() + self.assertRaises(IndexError, clfactory.GetNextClient) + + (exp_job_id, (op, )) = cl.GetNextSubmittedJob() + self.assertEqual(job_id, exp_job_id) + self.assertTrue(isinstance(op, opcodes.OpGroupAssignNodes)) + self.assertEqual(op.group_name, "grp-a") + self.assertEqual(op.nodes, ["n2", "n3"]) + self.assertTrue(op.dry_run) + self.assertTrue(op.force) + + self.assertRaises(IndexError, cl.GetNextSubmittedJob) + + class TestParseInstanceCreateRequestVersion1(testutils.GanetiTestCase): def setUp(self): testutils.GanetiTestCase.setUp(self)