diff --git a/lib/cmdlib.py b/lib/cmdlib.py index f0f5d19479d029b09816086d3d06d2c1462c4f74..b8b53d7c681bd99d8303f2bdfded391c671fbc19 100644 --- a/lib/cmdlib.py +++ b/lib/cmdlib.py @@ -4974,7 +4974,8 @@ def _ShutdownInstanceDisks(lu, instance, disks=None, ignore_primary=False): if msg: lu.LogWarning("Could not shutdown block device %s on node %s: %s", disk.iv_name, node, msg) - if not ignore_primary or node != instance.primary_node: + if ((node == instance.primary_node and not ignore_primary) or + (node != instance.primary_node and not result.offline)): all_result = False return all_result @@ -9674,7 +9675,7 @@ class LUSetInstanceParams(LogicalUnit): if self.op.disk_template: r_shut = _ShutdownInstanceDisks(self, instance) if not r_shut: - raise errors.OpExecError("Cannot shutdow instance disks, unable to" + raise errors.OpExecError("Cannot shutdown instance disks, unable to" " proceed with disk template conversion") mode = (instance.disk_template, self.op.disk_template) try: