Commit 72729d6e authored by Michael Hanselmann's avatar Michael Hanselmann
Browse files

Cleanup bootstrap.SetupNodeDaemon

- Code formatting
- Use ShellQuote for one argument
- Remove variables no longer used after commit 9294514d

Signed-off-by: default avatarMichael Hanselmann <>
Reviewed-by: default avatarRené Nussbaumer <>
parent cee32223
...@@ -505,27 +505,7 @@ def SetupNodeDaemon(cluster_name, node, ssh_key_check): ...@@ -505,27 +505,7 @@ def SetupNodeDaemon(cluster_name, node, ssh_key_check):
""" """
family = ssconf.SimpleStore().GetPrimaryIPFamily() family = ssconf.SimpleStore().GetPrimaryIPFamily()
sshrunner = ssh.SshRunner(cluster_name, sshrunner = ssh.SshRunner(cluster_name, ipv6=(family ==
noded_cert = utils.ReadFile(constants.NODED_CERT_FILE)
rapi_cert = utils.ReadFile(constants.RAPI_CERT_FILE)
confd_hmac_key = utils.ReadFile(constants.CONFD_HMAC_KEY)
# in the base64 pem encoding, neither '!' nor '.' are valid chars,
# so we use this to detect an invalid certificate; as long as the
# cert doesn't contain this, the here-document will be correctly
# parsed by the shell sequence below. HMAC keys are hexadecimal strings,
# so the same restrictions apply.
for content in (noded_cert, rapi_cert, confd_hmac_key):
if'^!EOF\.', content, re.MULTILINE):
raise errors.OpExecError("invalid SSL certificate or HMAC key")
if not noded_cert.endswith("\n"):
noded_cert += "\n"
if not rapi_cert.endswith("\n"):
rapi_cert += "\n"
if not confd_hmac_key.endswith("\n"):
confd_hmac_key += "\n"
bind_address = constants.IP4_ADDRESS_ANY bind_address = constants.IP4_ADDRESS_ANY
if family == if family ==
...@@ -538,10 +518,9 @@ def SetupNodeDaemon(cluster_name, node, ssh_key_check): ...@@ -538,10 +518,9 @@ def SetupNodeDaemon(cluster_name, node, ssh_key_check):
sshrunner.CopyFileToNode(node, constants.NODED_CERT_FILE) sshrunner.CopyFileToNode(node, constants.NODED_CERT_FILE)
sshrunner.CopyFileToNode(node, constants.RAPI_CERT_FILE) sshrunner.CopyFileToNode(node, constants.RAPI_CERT_FILE)
sshrunner.CopyFileToNode(node, constants.CONFD_HMAC_KEY) sshrunner.CopyFileToNode(node, constants.CONFD_HMAC_KEY)
mycommand = ("%s stop-all; %s start %s -b '%s'" % (constants.DAEMON_UTIL, mycommand = ("%s stop-all; %s start %s -b %s" %
constants.DAEMON_UTIL, (constants.DAEMON_UTIL, constants.DAEMON_UTIL, constants.NODED,
constants.NODED, utils.ShellQuote(bind_address)))
result = sshrunner.Run(node, 'root', mycommand, batch=False, result = sshrunner.Run(node, 'root', mycommand, batch=False,
ask_key=ssh_key_check, ask_key=ssh_key_check,
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment