Commit 727274dd authored by Iustin Pop's avatar Iustin Pop
Browse files

Tiny optimisation related to filter parsing



Currently, we get a luxi Client, then parse the filter, then execute
the query. If parsing the filter fails, we connected to the masterd
needlessly.
Signed-off-by: default avatarIustin Pop <iustin@google.com>
Reviewed-by: default avatarMichael Hanselmann <hansmi@google.com>
parent a629ecb9
......@@ -2688,14 +2688,14 @@ def GenericList(resource, fields, names, unit, separator, header, cl=None,
@param verbose: whether to use verbose field descriptions or not
"""
if cl is None:
cl = GetClient()
if not names:
names = None
qfilter = qlang.MakeFilter(names, force_filter)
if cl is None:
cl = GetClient()
response = cl.Query(resource, fields, qfilter)
found_unknown = _WarnUnknownFields(response.fields)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment