Commit 71c1af58 authored by Iustin Pop's avatar Iustin Pop
Browse files

Allow querying of variable number of parameters

This patch adds support for querying in gnt-instance list of:
  - disk.count
  - nic.count
  - disk.size/$N
  - nic.(ip|mac|bridge)/$N

The patch also disables the exception raised when the header description
is missing, that should be fixed in the future (together with better
handling of variable numeric fields).

Reviewed-by: imsnah
parent 31bf511f
......@@ -755,8 +755,10 @@ def GenerateTable(headers, fields, separator, data,
format_fields = []
for field in fields:
if headers and field not in headers:
raise errors.ProgrammerError("Missing header description for field '%s'"
% field)
# FIXME: handle better unknown fields (either revert to old
# style of raising exception, or deal more intelligently with
# variable fields)
headers[field] = field
if separator is not None:
elif field in numfields:
......@@ -2719,6 +2719,9 @@ class LUQueryInstances(NoHooksLU):
"disk_template", "ip", "mac", "bridge",
"sda_size", "sdb_size", "vcpus", "tags",
"network_port", "beparams",
"serial_no", "hypervisor", "hvparams",] +
["hv/%s" % name
for name in constants.HVS_PARAMETERS] +
......@@ -2806,6 +2809,7 @@ class LUQueryInstances(NoHooksLU):
i_hv = self.cfg.GetClusterInfo().FillHV(instance)
i_be = self.cfg.GetClusterInfo().FillBE(instance)
for field in self.op.output_fields:
st_match = self._FIELDS_STATIC.Matches(field)
if field == "name":
val =
elif field == "os":
......@@ -2875,6 +2879,39 @@ class LUQueryInstances(NoHooksLU):
elif (field.startswith(BEPREFIX) and
field[len(BEPREFIX):] in constants.BES_PARAMETERS):
val = i_be.get(field[len(BEPREFIX):], None)
elif st_match and st_match.groups():
# matches a variable list
st_groups = st_match.groups()
if st_groups and st_groups[0] == "disk":
if st_groups[1] == "count":
val = len(instance.disks)
elif st_groups[1] == "size":
disk_idx = int(st_groups[2])
if disk_idx >= len(instance.disks):
val = None
val = instance.disks[disk_idx].size
assert False, "Unhandled disk parameter"
elif st_groups[0] == "nic":
if st_groups[1] == "count":
val = len(instance.nics)
# index-based item
nic_idx = int(st_groups[2])
if nic_idx >= len(instance.nics):
val = None
if st_groups[1] == "mac":
val = instance.nics[nic_idx].mac
elif st_groups[1] == "ip":
val = instance.nics[nic_idx].ip
elif st_groups[1] == "bridge":
val = instance.nics[nic_idx].bridge
assert False, "Unhandled NIC parameter"
assert False, "Unhandled variable parameter"
raise errors.ParameterError(field)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment