diff --git a/Makefile.am b/Makefile.am index 8dbd86bbd1fae2163d67456f6b25eb0943eb7cf5..268436cae0a7de0ab26c2eb985b171d8f1343e4a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -378,9 +378,10 @@ python_tests = \ test/tempfile_fork_unittest.py dist_TESTS = \ + test/check-cert-expired_unittest.bash \ test/daemon-util_unittest.bash \ + test/ganeti-cleaner_unittest.bash \ test/import-export_unittest.bash \ - test/check-cert-expired_unittest.bash \ $(python_tests) nodist_TESTS = @@ -411,9 +412,10 @@ all_python_code = \ srclink_files = \ man/footer.sgml \ + test/check-cert-expired_unittest.bash \ test/daemon-util_unittest.bash \ + test/ganeti-cleaner_unittest.bash \ test/import-export_unittest.bash \ - test/check-cert-expired_unittest.bash \ $(all_python_code) check_python_code = \ @@ -429,6 +431,8 @@ lint_python_code = \ test/daemon-util_unittest.bash: daemons/daemon-util +test/ganeti-cleaner_unittest.bash: daemons/ganeti-cleaner + devel/upload: devel/upload.in $(REPLACE_VARS_SED) sed -f $(REPLACE_VARS_SED) < $< > $@ chmod u+x $@ diff --git a/daemons/ganeti-cleaner.in b/daemons/ganeti-cleaner.in index 59fd08ed613bf4b8433fefd811427d79c9972f23..7902c52a91e352eb735a3a4c4f42b7131a44afd4 100755 --- a/daemons/ganeti-cleaner.in +++ b/daemons/ganeti-cleaner.in @@ -1,7 +1,7 @@ #!/bin/bash # -# Copyright (C) 2009 Google Inc. +# Copyright (C) 2009, 2010 Google Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -45,11 +45,14 @@ cleanup_node() { done } -DATA_DIR=@LOCALSTATEDIR@/lib/ganeti -CLEANER_LOG_DIR=@LOCALSTATEDIR@/log/ganeti/cleaner +# Overridden by unittest +: ${LOCALSTATEDIR:=@LOCALSTATEDIR@} +: ${CHECK_CERT_EXPIRED:=@PKGLIBDIR@/check-cert-expired} + +DATA_DIR=$LOCALSTATEDIR/lib/ganeti +CLEANER_LOG_DIR=$LOCALSTATEDIR/log/ganeti/cleaner QUEUE_ARCHIVE_DIR=$DATA_DIR/queue/archive -CRYPTO_DIR=@LOCALSTATEDIR@/run/ganeti/crypto -CHECK_CERT_EXPIRED=@PKGLIBDIR@/check-cert-expired +CRYPTO_DIR=$LOCALSTATEDIR/run/ganeti/crypto # Define how many days archived jobs should be left alone REMOVE_AFTER=21 diff --git a/test/ganeti-cleaner_unittest.bash b/test/ganeti-cleaner_unittest.bash new file mode 100755 index 0000000000000000000000000000000000000000..548c13664583db5f4d436b798c82ae2702a6e7a7 --- /dev/null +++ b/test/ganeti-cleaner_unittest.bash @@ -0,0 +1,170 @@ +#!/bin/bash +# + +# Copyright (C) 2010 Google Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, but +# WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA +# 02110-1301, USA. + +set -e +set -o pipefail + +export PYTHON=${PYTHON:=python} + +GNTC=daemons/ganeti-cleaner +CCE=tools/check-cert-expired + +err() { + echo "$@" + echo 'Aborting' + exit 1 +} + +upto() { + echo "$(date '+%F %T'):" "$@" '...' +} + +gencert() { + local path=$1 validity=$2 + VALIDITY=$validity $PYTHON \ + ${TOP_SRCDIR:-.}/test/import-export_unittest-helper \ + $path gencert +} + +check_logfiles() { + local n=$1 + [[ "$(find $tmpls/log/ganeti/cleaner -mindepth 1 | wc -l)" -le "$n" ]] || \ + err "Found more than $n logfiles" +} + +count_jobs() { + local n=$1 + local count=$(find $queuedir -mindepth 1 -type f | wc -l) + [[ "$count" -eq "$n" ]] || err "Found $count jobs instead of $n" +} + +count_and_check_certs() { + local n=$1 + local count=$(find $cryptodir -mindepth 1 -type f -name cert | wc -l) + [[ "$count" -eq "$n" ]] || err "Found $count certificates instead of $n" + + find $cryptodir -mindepth 1 -type d | \ + while read dir; do + [[ ( -e $dir/key && -e $dir/cert ) || + ( ! -e $dir/cert && ! -e $dir/key ) ]] || \ + err 'Inconsistent cert/key directory found' + done +} + +run_cleaner() { + CHECK_CERT_EXPIRED=$CCE LOCALSTATEDIR=$tmpls $GNTC +} + +create_archived_jobs() { + local i jobdir touchargs + local jobarchive=$queuedir/archive + local large=$(( RANDOM * RANDOM )) + local old_ts=$(date -d '25 days ago' +%Y%m%d%H%M) + + # Remove jobs from previous run + find $jobarchive -mindepth 1 -type f | xargs -r rm + + i=0 + for job_id in {1..50} $(( large % RANDOM )) $RANDOM \ + $(( large - 1 )) $large $(( large + 1 )) + do + jobdir=$jobarchive/$(( job_id / 10 )) + test -d $jobdir || mkdir $jobdir + + if (( i % 3 == 0 || i % 7 == 0 )); then + touchargs="-t $old_ts" + else + touchargs= + fi + touch $touchargs $jobdir/job-$job_id + + let ++i + done +} + +create_certdirs() { + local cert=$1; shift + local certdir + for name in "$@"; do + certdir=$cryptodir/$name + mkdir $certdir + if [[ -n "$cert" ]]; then + cp $cert $certdir/cert + cp $cert $certdir/key + fi + done +} + +tmpdir=$(mktemp -d) +trap "rm -rf $tmpdir" EXIT + +# Temporary localstatedir +tmpls=$tmpdir/var +queuedir=$tmpls/lib/ganeti/queue +cryptodir=$tmpls/run/ganeti/crypto + +mkdir -p $tmpls/{lib,log,run}/ganeti $queuedir/archive $cryptodir + +maxlog=50 + +upto 'Checking log directory creation' +test -d $tmpls/log/ganeti || err 'log/ganeti does not exist' +test -d $tmpls/log/ganeti/cleaner && \ + err 'log/ganeti/cleaner should not exist yet' +run_cleaner +test -d $tmpls/log/ganeti/cleaner || err 'log/ganeti/cleaner should exist' +check_logfiles 1 + +upto 'Checking number of retained log files' +for (( i=0; i < (maxlog + 10); ++i )); do + run_cleaner + check_logfiles $(( (i + 2) > $maxlog?$maxlog:(i + 2) )) +done + +upto 'Removal of archived jobs (non-master)' +create_archived_jobs +count_jobs 55 +test -f $tmpls/lib/ganeti/ssconf_master_node && \ + err 'ssconf_master_node should not exist' +run_cleaner +count_jobs 55 + +upto 'Removal of archived jobs (master node)' +create_archived_jobs +count_jobs 55 +echo $HOSTNAME > $tmpls/lib/ganeti/ssconf_master_node +run_cleaner +count_jobs 31 + +upto 'Certificate expiration' +gencert $tmpdir/validcert 30 & vcpid=${!} +gencert $tmpdir/expcert -30 & ecpid=${!} +wait $vcpid $ecpid +create_certdirs $tmpdir/validcert foo{a,b,c}123 trvRMH4Wvt OfDlh6Pc2n +create_certdirs $tmpdir/expcert bar{x,y,z}999 fx0ljoImWr em3RBC0U8c +create_certdirs '' empty{1,2,3} gd2HCvRc iFG55Z0a PP28v5kg +count_and_check_certs 10 +run_cleaner +count_and_check_certs 5 + +check_logfiles $maxlog +count_jobs 31 + +exit 0