Commit 708f8301 authored by Helga Velroyen's avatar Helga Velroyen
Browse files

Remove FIXME + update man pages wrt iallocator

This patch removes a FIXME regarding the retrieval
of the disk template for computation of the cluster
information for the iallocator. After examining the
code, I figured out that it is actually a quite
robust way to just check if the disk template is
available, in particular with respect to extensions
of the iallocator.

In this context, I also updated the man pages of
the operations that use the iallocator, because so
far it was not well documented which disk template
is considered when more than one instance was
allocated. The situation is not ideal (the default
disk template is used), but it is still better than
in 2.9. where only LVM storage was considered.
With the implementation of storage pools, it would
make sense to extend the iallocator protocol to
include storage information for more than one
Signed-off-by: default avatarHelga Velroyen <>
Reviewed-by: default avatarKlaus Aehlig <>
parent d5e9de7c
......@@ -761,7 +761,6 @@ class IAllocator(object):
request = req.GetRequest(self.cfg)
disk_template = None
# FIXME: decide this based on request mode
if "disk_template" in request:
disk_template = request["disk_template"]
......@@ -992,6 +992,14 @@ follows::
# gnt-instance batch-create instances.json
Submitted jobs 37, 38
Note: If the allocator is used for computing suitable nodes for the
instances, it will only take into account disk information for the
default disk template. That means, even if other disk templates are
specified for the instances, storage space information of these disk
templates will not be considered in the allocation computation.
......@@ -1921,7 +1929,9 @@ CHANGE-GROUP
This command moves an instance to another node group. The move is
calculated by an iallocator, either given on the command line or as a
cluster default.
cluster default. Note that the iallocator does only consider disk
information of the default disk template, even if the instances'
disk templates differ from that.
If no specific destination groups are specified using ``--to``, all
groups except the one containing the instance are considered.
......@@ -123,6 +123,10 @@ each affected instance individually:
instance that the node is a secondary for.
- when neither of the above is done a combination of the two cases is run
Note that the iallocator currently only considers disk information of
the default disk template, even if the instance's disk templates differ
from that.
See **ganeti**\(7) for a description of ``--submit`` and other common
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment