From 674711dee497320fb424fbe84b84224aa2b2be5c Mon Sep 17 00:00:00 2001
From: Michael Hanselmann <hansmi@google.com>
Date: Tue, 23 Aug 2011 15:12:44 +0200
Subject: [PATCH] check-python-code: Give location(s) of lines longer than 80
chars
Until now it would only say that there was a line longer than 80
characters, but not where.
Signed-off-by: Michael Hanselmann <hansmi@google.com>
Reviewed-by: Iustin Pop <iustin@google.com>
---
autotools/check-python-code | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/autotools/check-python-code b/autotools/check-python-code
index ec1d96bc2..166e12db1 100755
--- a/autotools/check-python-code
+++ b/autotools/check-python-code
@@ -20,6 +20,13 @@
set -e
+readonly maxlinelen=$(for ((i=0; i<81; ++i)); do echo -n .; done)
+
+if [[ "${#maxlinelen}" != 81 ]]; then
+ echo "Internal error: Check for line length is incorrect" >&2
+ exit 1
+fi
+
# "[...] If the last ARG evaluates to 0, let returns 1; 0 is returned
# otherwise.", hence ignoring the return value.
let problems=0 || :
@@ -47,7 +54,7 @@ for script; do
echo "Found editor-specific settings in $script" >&2
fi
- if [[ "$(wc --max-line-length < "$script")" -gt 80 ]]; then
+ if grep -n -H "^$maxlinelen" "$script"; then
let ++problems
echo "Longest line in $script is longer than 80 characters" >&2
fi
--
GitLab