Commit 66d5dbef authored by Guido Trotter's avatar Guido Trotter
Browse files

Support cdrom image and boot order for KVM

The cdrom image has the same meaning than in Xen HVM, and so does
boot_order, even though it has a slightly different syntax, and uses the
value 'disk' too boot from disk and 'cdrom' to boot from cdrom.

Reviewed-by: iustinp
parent 30948aa6
......@@ -459,6 +459,8 @@ HVC_DEFAULTS = {
HV_VNC_TLS: False,
HV_VNC_X509: '',
HV_VNC_X509_VERIFY: False,
HV_BOOT_ORDER: "disk",
......@@ -58,6 +58,8 @@ class KVMHypervisor(hv_base.BaseHypervisor):
_MIGRATION_STATUS_RE = re.compile('Migration\s+status:\s+(\w+)',
......@@ -230,15 +232,16 @@ class KVMHypervisor(hv_base.BaseHypervisor):
if not instance.hvparams[constants.HV_ACPI]:
boot_drive = True
boot_disk = (instance.hvparams[constants.HV_BOOT_ORDER] == "disk")
boot_cdrom = (instance.hvparams[constants.HV_BOOT_ORDER] == "cdrom")
for cfdev, dev_path in block_devices:
if cfdev.mode != constants.DISK_RDWR:
raise errors.HypervisorError("Instance has read-only disks which"
" are not supported by KVM")
# TODO: handle FD_LOOP and FD_BLKTAP (?)
if boot_drive:
if boot_disk:
boot_val = ',boot=on'
boot_drive = False
boot_disk = False
boot_val = ''
......@@ -248,6 +251,14 @@ class KVMHypervisor(hv_base.BaseHypervisor):
drive_val = 'file=%s,format=raw%s%s' % (dev_path, if_val, boot_val)
kvm_cmd.extend(['-drive', drive_val])
iso_image = instance.hvparams[constants.HV_CDROM_IMAGE_PATH]
if iso_image:
options = ',format=raw,if=virtio,media=cdrom'
if boot_cdrom:
options = '%s,boot=on' % options
drive_val = 'file=%s%s' % (iso_image, options)
kvm_cmd.extend(['-drive', drive_val])
kernel_path = instance.hvparams[constants.HV_KERNEL_PATH]
if kernel_path:
kvm_cmd.extend(['-kernel', kernel_path])
......@@ -260,9 +271,6 @@ class KVMHypervisor(hv_base.BaseHypervisor):
kvm_cmd.extend(['-append', root_append])
# FIXME: handle vnc password
vnc_bind_address = instance.hvparams[constants.HV_VNC_BIND_ADDRESS]
if vnc_bind_address:
......@@ -722,6 +730,15 @@ class KVMHypervisor(hv_base.BaseHypervisor):
raise errors.HypervisorError("The vnc x509 path must an absolute path"
", if defined")
iso_path = hvparams[constants.HV_CDROM_IMAGE_PATH]
if iso_path and not os.path.isabs(iso_path):
raise errors.HypervisorError("The path to the CDROM image must be"
" an absolute path, if defined")
boot_order = hvparams[constants.HV_BOOT_ORDER]
if boot_order not in ('cdrom', 'disk'):
raise errors.HypervisorError("The boot order must be 'cdrom' or 'disk'")
def ValidateParameters(self, hvparams):
"""Check the given parameters for validity.
......@@ -751,3 +768,9 @@ class KVMHypervisor(hv_base.BaseHypervisor):
raise errors.HypervisorError("Instance vnc x509 path '%s' not found"
" or not a directory" % vnc_x509)
iso_path = hvparams[constants.HV_CDROM_IMAGE_PATH]
if iso_path and not os.path.isfile(iso_path):
raise errors.HypervisorError("Instance cdrom image '%s' not found or"
" not a file" % iso_path)
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment