diff --git a/lib/utils.py b/lib/utils.py index 6744358222ce075825914cd0ac502a82d3f02c46..143ca09d97f0f42138fbc3a4eaf41deae8b637d0 100644 --- a/lib/utils.py +++ b/lib/utils.py @@ -1056,7 +1056,7 @@ def Daemonize(logfile, noclose_fds=None): return 0 -def _DaemonPidFileName(name): +def DaemonPidFileName(name): """Compute a ganeti pid file absolute path, given the daemon name. """ @@ -1070,7 +1070,7 @@ def WritePidFile(name): """ pid = os.getpid() - pidfilename = _DaemonPidFileName(name) + pidfilename = DaemonPidFileName(name) if IsProcessAlive(ReadPidFile(pidfilename)): raise errors.GenericError("%s contains a live process" % pidfilename) @@ -1084,7 +1084,7 @@ def RemovePidFile(name): """ pid = os.getpid() - pidfilename = _DaemonPidFileName(name) + pidfilename = DaemonPidFileName(name) # TODO: we could check here that the file contains our pid try: RemoveFile(pidfilename) diff --git a/test/ganeti.utils_unittest.py b/test/ganeti.utils_unittest.py index 9a9eed94880bc5cbfbb519e78605f25134e863de..405a24101b94f7c9ae9bc6e636bc49e65384985e 100755 --- a/test/ganeti.utils_unittest.py +++ b/test/ganeti.utils_unittest.py @@ -108,7 +108,7 @@ class TestPidFileFunctions(unittest.TestCase): def setUp(self): self.dir = tempfile.mkdtemp() self.f_dpn = lambda name: os.path.join(self.dir, "%s.pid" % name) - utils._DaemonPidFileName = self.f_dpn + utils.DaemonPidFileName = self.f_dpn def testPidFileFunctions(self): pid_file = self.f_dpn('test')