From 52bebbdfcf9ba4679e4303f3b912559cf0bc5ec5 Mon Sep 17 00:00:00 2001 From: Iustin Pop <iustin@google.com> Date: Thu, 26 Jul 2012 13:24:58 +0200 Subject: [PATCH] Add QA test for node group modification of ndparams Additionally, we run hbal if the htools tests are enabled (new key). Note that hbal will directly exit, since there are no instances, but at least it will load and parse the group details. Signed-off-by: Iustin Pop <iustin@google.com> Reviewed-by: Guido Trotter <ultrotter@google.com> --- qa/qa-sample.json | 1 + qa/qa_group.py | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/qa/qa-sample.json b/qa/qa-sample.json index dc033acc3..25d061e3c 100644 --- a/qa/qa-sample.json +++ b/qa/qa-sample.json @@ -96,6 +96,7 @@ "cluster-repair-disk-sizes": true, "haskell-confd": true, + "htools": true, "group-list": true, "group-rwops": true, diff --git a/qa/qa_group.py b/qa/qa_group.py index 2adc62074..b72ff0297 100644 --- a/qa/qa_group.py +++ b/qa/qa_group.py @@ -1,7 +1,7 @@ # # -# Copyright (C) 2010, 2011 Google Inc. +# Copyright (C) 2010, 2011, 2012 Google Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -103,6 +103,12 @@ def TestGroupModify(): "min=%s,max=%s,std=0" % (min_v, max_v), group1], fail=True) AssertCommand(["gnt-group", "modify", "--specs-mem-size", "min=%s,max=%s" % (min_v, max_v), group1]) + AssertCommand(["gnt-group", "modify", + "--node-parameters", "spindle_count=10", group1]) + if qa_config.TestEnabled("htools"): + AssertCommand(["hbal", "-L", "-G", group1]) + AssertCommand(["gnt-group", "modify", + "--node-parameters", "spindle_count=default", group1]) finally: AssertCommand(["gnt-group", "remove", group1]) -- GitLab