From 360e6c0829576955b44e44bdfad58117fa3bb781 Mon Sep 17 00:00:00 2001 From: Guido Trotter <ultrotter@google.com> Date: Mon, 24 Jun 2013 16:45:00 +0200 Subject: [PATCH] kvm: don't pass whole extra as a single argument If extra is longer than a single word passing it the way it was passed won't work. Of course this solution is also only partial, as won't take into account any form of quoting. :/ Signed-off-by: Guido Trotter <ultrotter@google.com> Reviewed-by: Klaus Aehlig <aehlig@google.com> --- lib/hypervisor/hv_kvm.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hypervisor/hv_kvm.py b/lib/hypervisor/hv_kvm.py index 37058e71c..b2d158de8 100644 --- a/lib/hypervisor/hv_kvm.py +++ b/lib/hypervisor/hv_kvm.py @@ -1369,7 +1369,7 @@ class KVMHypervisor(hv_base.BaseHypervisor): kvm_cmd.extend(["-usbdevice", dev]) if hvp[constants.HV_KVM_EXTRA]: - kvm_cmd.extend([hvp[constants.HV_KVM_EXTRA]]) + kvm_cmd.extend([hvp[constants.HV_KVM_EXTRA].split(" ")]) # Save the current instance nics, but defer their expansion as parameters, # as we'll need to generate executable temp files for them. -- GitLab