From 3517d9b9aeb4b30d5d46eed81f103af95f595027 Mon Sep 17 00:00:00 2001
From: Manuel Franceschini <manuel.franceschini@gmail.com>
Date: Mon, 25 Feb 2008 09:17:51 +0000
Subject: [PATCH] This patch replaces some hardcoded strings with their
corresponding constant in `_GenerateDiskTemplate()`.
Reviewed-by: iustinp
---
lib/cmdlib.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/cmdlib.py b/lib/cmdlib.py
index 173cb1600..65c52a284 100644
--- a/lib/cmdlib.py
+++ b/lib/cmdlib.py
@@ -2741,9 +2741,9 @@ def _GenerateDiskTemplate(cfg, template_name,
#TODO: compute space requirements
vgname = cfg.GetVGName()
- if template_name == "diskless":
+ if template_name == constants.DT_DISKLESS:
disks = []
- elif template_name == "plain":
+ elif template_name == constants.DT_PLAIN:
if len(secondary_nodes) != 0:
raise errors.ProgrammerError("Wrong template configuration")
@@ -2755,7 +2755,7 @@ def _GenerateDiskTemplate(cfg, template_name,
logical_id=(vgname, names[1]),
iv_name = "sdb")
disks = [sda_dev, sdb_dev]
- elif template_name == "local_raid1":
+ elif template_name == constants.DT_LOCAL_RAID1:
if len(secondary_nodes) != 0:
raise errors.ProgrammerError("Wrong template configuration")
--
GitLab