From 26a61f87506324fb008a7168d65704742b8496f1 Mon Sep 17 00:00:00 2001 From: Michael Hanselmann <hansmi@google.com> Date: Fri, 5 Sep 2008 12:19:17 +0000 Subject: [PATCH] QA: Remove dry run mode It didn't work as planned because some commands depend on the return value or output of some operations. Reviewed-by: iustinp --- qa/ganeti-qa.py | 3 --- qa/qa_utils.py | 8 +------- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/qa/ganeti-qa.py b/qa/ganeti-qa.py index 727af9784..1bd4d5cdb 100755 --- a/qa/ganeti-qa.py +++ b/qa/ganeti-qa.py @@ -237,9 +237,6 @@ def main(): """ parser = optparse.OptionParser(usage="%prog [options] <config-file>") - parser.add_option('--dry-run', dest='dry_run', - action="store_true", - help="Show what would be done") parser.add_option('--yes-do-it', dest='yes_do_it', action="store_true", help="Really execute the tests") diff --git a/qa/qa_utils.py b/qa/qa_utils.py index 0ba6cb92d..fbc92e8e7 100644 --- a/qa/qa_utils.py +++ b/qa/qa_utils.py @@ -111,13 +111,7 @@ def GetSSHCommand(node, cmd, strict=True): args.append('-oClearAllForwardings=yes') args.append('-oForwardAgent=yes') args.append(node) - - if qa_config.options.dry_run: - prefix = 'exit 0; ' - else: - prefix = '' - - args.append(prefix + cmd) + args.append(cmd) print 'SSH:', utils.ShellQuoteArgs(args) -- GitLab